From: Matthew Wilcox <matthew@wil.cx>
To: "Ju, Seokmann" <Seokmann.Ju@lsil.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
__smail D?nmez <ismail@pardus.org.tr>,
scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>,
jejb <james.bottomley@steeleye.com>,
"Kolli, Neela" <Neela.Kolli@engenio.com>
Subject: Re: [PATCH] megaraid_mbox: fix section mismatch warnings
Date: Wed, 31 May 2006 06:30:29 -0600 [thread overview]
Message-ID: <20060531123029.GF1610@parisc-linux.org> (raw)
In-Reply-To: <890BF3111FB9484E9526987D912B261901BD9C@NAMAIL3.ad.lsil.com>
On Tue, May 30, 2006 at 11:11:59AM -0600, Ju, Seokmann wrote:
> > Why would you want to do that? A subfunction of a __devinit function
> > should also be __devinit (unless it's alsoi used by something which
> > isn't __devinit, of course)
> For similar reason as you pointed out, I thought it would be good to remove (unless it is required) the tag so that it can be called by any functions in the driver if needed be.
If it turns out you want to call it from elsewhere in the driver, you
should remove the __devinit tag at that time.
> I don't have enough knowledge on the topic, unfortunately. Is it hardly required to have the tag on all sub-functions called in the function?
> If so, there are couple of other sub-functions need to have the tag.
It's not required, but it is a good idea. Marking the function as
__devinit allows the function to be discarded when we know it can't be
called again (an infrequent case these days, to be sure, but one the
embedded people are grateful for).
next prev parent reply other threads:[~2006-05-31 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 17:11 [PATCH] megaraid_mbox: fix section mismatch warnings Ju, Seokmann
2006-05-31 12:30 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-30 13:37 Ju, Seokmann
2006-05-30 15:53 ` Randy.Dunlap
2006-05-30 17:03 ` Matthew Wilcox
2006-05-25 16:46 Randy.Dunlap
2006-05-25 21:39 ` Andrew Morton
2006-05-25 21:54 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060531123029.GF1610@parisc-linux.org \
--to=matthew@wil.cx \
--cc=Neela.Kolli@engenio.com \
--cc=Seokmann.Ju@lsil.com \
--cc=akpm@osdl.org \
--cc=ismail@pardus.org.tr \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).