From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: Christoph Hellwig <hch@lst.de>,
jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix up request buffer reference in various scsi drivers
Date: Thu, 8 Jun 2006 07:01:14 -0600 [thread overview]
Message-ID: <20060608130114.GG1651@parisc-linux.org> (raw)
In-Reply-To: <44880BEA.90707@garzik.org>
On Thu, Jun 08, 2006 at 07:37:14AM -0400, Jeff Garzik wrote:
> Christoph Hellwig wrote:
> >Various scsi drivers use scsi_cmnd.buffer and scsi_cmnd.bufflen in their
> >queuecommand functions. Those fields are internal storage for the
> >midlayer only and are used to restore the original payload after
> >request_buffer and request_bufflen have been overwritten for EH. Using
> >the buffer and bufflen fields means they do very broken things in error
> >handling.
>
> False statement, for libata.
Why? I don't see anywhere in libata where it touches ->buffer or
->bufflen other than the two cases Christoph removed.
next prev parent reply other threads:[~2006-06-08 13:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 11:21 [PATCH] fix up request buffer reference in various scsi drivers Christoph Hellwig
2006-06-08 11:37 ` Jeff Garzik
2006-06-08 13:01 ` Matthew Wilcox [this message]
2006-06-08 13:06 ` James Bottomley
2006-06-08 13:26 ` Jeff Garzik
2006-06-08 13:54 ` James Bottomley
2006-06-08 14:17 ` Jeff Garzik
2006-06-08 14:35 ` James Bottomley
2006-06-08 14:44 ` Jeff Garzik
2006-06-08 17:40 ` James Bottomley
2006-06-08 17:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608130114.GG1651@parisc-linux.org \
--to=matthew@wil.cx \
--cc=hch@lst.de \
--cc=jeff@garzik.org \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).