* [patch 30/31] scsi: clean up warnings in Advansys driver
@ 2006-06-09 5:24 akpm
2006-06-09 6:53 ` Jeffrey Phillips Freeman
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2006-06-09 5:24 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, ken, jeffreyfreeman
From: Ken Witherow <ken@krwtech.com>
Fix typecast warnings and switch from check_region to request_region
(akpm: Ken and Jeffrey Phillips Freeman <jeffreyfreeman@syncleus.com> are
possible advansys testers)
Signed-off-by: Ken Witherow <ken@krwtech.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/scsi/advansys.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/advansys.c~scsi-clean-up-warnings-in-advansys-driver drivers/scsi/advansys.c
--- devel/drivers/scsi/advansys.c~scsi-clean-up-warnings-in-advansys-driver 2006-04-30 00:13:25.000000000 -0700
+++ devel-akpm/drivers/scsi/advansys.c 2006-04-30 00:13:25.000000000 -0700
@@ -4415,7 +4415,7 @@ advansys_detect(struct scsi_host_templat
ASC_DBG1(1,
"advansys_detect: probing I/O port 0x%x...\n",
iop);
- if (check_region(iop, ASC_IOADR_GAP) != 0) {
+ if (!request_region(iop, ASC_IOADR_GAP, "advansys")){
printk(
"AdvanSys SCSI: specified I/O Port 0x%X is busy\n", iop);
/* Don't try this I/O port twice. */
@@ -4425,6 +4425,7 @@ advansys_detect(struct scsi_host_templat
printk(
"AdvanSys SCSI: specified I/O Port 0x%X has no adapter\n", iop);
/* Don't try this I/O port twice. */
+ release_region(iop, ASC_IOADR_GAP);
asc_ioport[ioport] = 0;
goto ioport_try_again;
} else {
@@ -4443,6 +4444,7 @@ advansys_detect(struct scsi_host_templat
* 'ioport' past this board.
*/
ioport++;
+ release_region(iop, ASC_IOADR_GAP);
goto ioport_try_again;
}
}
@@ -9752,13 +9754,14 @@ AscSearchIOPortAddr11(
}
for (; i < ASC_IOADR_TABLE_MAX_IX; i++) {
iop_base = _asc_def_iop_base[i];
- if (check_region(iop_base, ASC_IOADR_GAP) != 0) {
+ if (!request_region(iop_base, ASC_IOADR_GAP, "advansys")){
ASC_DBG1(1,
"AscSearchIOPortAddr11: check_region() failed I/O port 0x%x\n",
iop_base);
continue;
}
ASC_DBG1(1, "AscSearchIOPortAddr11: probing I/O port 0x%x\n", iop_base);
+ release_region(iop_base, ASC_IOADR_GAP);
if (AscFindSignature(iop_base)) {
return (iop_base);
}
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 30/31] scsi: clean up warnings in Advansys driver
2006-06-09 5:24 [patch 30/31] scsi: clean up warnings in Advansys driver akpm
@ 2006-06-09 6:53 ` Jeffrey Phillips Freeman
2006-06-09 7:04 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jeffrey Phillips Freeman @ 2006-06-09 6:53 UTC (permalink / raw)
To: akpm; +Cc: James.Bottomley, linux-scsi, ken
Oh, its great to see my name on the advansys list as a tester. You
almost got filed away with the rest of my spam. I would love to test
this patch but before i do is there some howto or overview document to
help familarize me as a tester. I am comfortable with linuc and the
kernel as well as patching. But i wasnt sure if there was a perticular
version of the kernal i should try this patch on or a procedure i should
follow. Any information that can be provided to go about this properly
would be apprecaited. I would love to contribute, and if im going to
contribute it should be done right!
akpm@osdl.org wrote:
>From: Ken Witherow <ken@krwtech.com>
>
>Fix typecast warnings and switch from check_region to request_region
>
>(akpm: Ken and Jeffrey Phillips Freeman <jeffreyfreeman@syncleus.com> are
>possible advansys testers)
>
>Signed-off-by: Ken Witherow <ken@krwtech.com>
>Signed-off-by: Andrew Morton <akpm@osdl.org>
>---
>
> drivers/scsi/advansys.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff -puN drivers/scsi/advansys.c~scsi-clean-up-warnings-in-advansys-driver drivers/scsi/advansys.c
>--- devel/drivers/scsi/advansys.c~scsi-clean-up-warnings-in-advansys-driver 2006-04-30 00:13:25.000000000 -0700
>+++ devel-akpm/drivers/scsi/advansys.c 2006-04-30 00:13:25.000000000 -0700
>@@ -4415,7 +4415,7 @@ advansys_detect(struct scsi_host_templat
> ASC_DBG1(1,
> "advansys_detect: probing I/O port 0x%x...\n",
> iop);
>- if (check_region(iop, ASC_IOADR_GAP) != 0) {
>+ if (!request_region(iop, ASC_IOADR_GAP, "advansys")){
> printk(
> "AdvanSys SCSI: specified I/O Port 0x%X is busy\n", iop);
> /* Don't try this I/O port twice. */
>@@ -4425,6 +4425,7 @@ advansys_detect(struct scsi_host_templat
> printk(
> "AdvanSys SCSI: specified I/O Port 0x%X has no adapter\n", iop);
> /* Don't try this I/O port twice. */
>+ release_region(iop, ASC_IOADR_GAP);
> asc_ioport[ioport] = 0;
> goto ioport_try_again;
> } else {
>@@ -4443,6 +4444,7 @@ advansys_detect(struct scsi_host_templat
> * 'ioport' past this board.
> */
> ioport++;
>+ release_region(iop, ASC_IOADR_GAP);
> goto ioport_try_again;
> }
> }
>@@ -9752,13 +9754,14 @@ AscSearchIOPortAddr11(
> }
> for (; i < ASC_IOADR_TABLE_MAX_IX; i++) {
> iop_base = _asc_def_iop_base[i];
>- if (check_region(iop_base, ASC_IOADR_GAP) != 0) {
>+ if (!request_region(iop_base, ASC_IOADR_GAP, "advansys")){
> ASC_DBG1(1,
> "AscSearchIOPortAddr11: check_region() failed I/O port 0x%x\n",
> iop_base);
> continue;
> }
> ASC_DBG1(1, "AscSearchIOPortAddr11: probing I/O port 0x%x\n", iop_base);
>+ release_region(iop_base, ASC_IOADR_GAP);
> if (AscFindSignature(iop_base)) {
> return (iop_base);
> }
>_
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 30/31] scsi: clean up warnings in Advansys driver
2006-06-09 6:53 ` Jeffrey Phillips Freeman
@ 2006-06-09 7:04 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-06-09 7:04 UTC (permalink / raw)
To: Jeffrey Phillips Freeman; +Cc: James.Bottomley, linux-scsi, ken
On Fri, 09 Jun 2006 02:53:41 -0400
Jeffrey Phillips Freeman <jeffreyfreeman@syncleus.com> wrote:
> Oh, its great to see my name on the advansys list as a tester. You
> almost got filed away with the rest of my spam. I would love to test
> this patch but before i do is there some howto or overview document to
> help familarize me as a tester. I am comfortable with linuc and the
> kernel as well as patching. But i wasnt sure if there was a perticular
> version of the kernal i should try this patch on or a procedure i should
> follow. Any information that can be provided to go about this properly
> would be apprecaited. I would love to contribute, and if im going to
> contribute it should be done right!
Thanks.
Nothing fancy is needed - it would be sufficient to use the most recentl
major release (2.6.15, 2.6.16, 2.6.17, etc) in your daily operations and
report any problems.
I made a note of this in the changelog because with some of these drivers
nobody has the hardware - if someone decided to do some maintenance work on
this driver it could be useful for them to ask you to regression test their
changes. They'd ask something like "please install 2.6.18-rc2 and let us
know if it breaks".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-09 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-09 5:24 [patch 30/31] scsi: clean up warnings in Advansys driver akpm
2006-06-09 6:53 ` Jeffrey Phillips Freeman
2006-06-09 7:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox