public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: vgoyal@in.ibm.com
Cc: Neela.Kolli@engenio.com, ebiederm@xmission.com,
	mike.miller@hp.com, linux-scsi@vger.kernel.org,
	fastboot@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 2/2] kdump: cciss driver initialization issue fix
Date: Mon, 26 Jun 2006 10:31:30 -0700	[thread overview]
Message-ID: <20060626103130.de79fd9f.akpm@osdl.org> (raw)
In-Reply-To: <20060626171659.GG8985@in.ibm.com>

On Mon, 26 Jun 2006 13:16:59 -0400
Vivek Goyal <vgoyal@in.ibm.com> wrote:

> So it is matter of making a choice in case the device does not have a
> software reset capability.
> 
> - Either try to make driver work through some hacks based on crashboot
>   option.
> 
> - Or mark the driver unusable in kdump scenarios.
> 
> Even if one decides to go for second option, at least "crashboot" or
> similar parameter will be required so that driver can choose whether
> to reset the device or not during initialization due to significant
> time penalty. 

yes, this does legitimise the `crashboot' option.

That being said, it's misnamed, I think.  It should be called
`reset_devices' or something.  Because that's what it does, and who
knows, there might be other reasons for wanting to reset devices.

See, it's more accurate.  We don't want drivers to be looking at some
global environmental thing and then independently working out what they
should be doing this time around.  We just want drivers to do what they're
told.

  reply	other threads:[~2006-06-26 17:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23 21:01 [RFC] [PATCH 1/2] introduce crashboot kernel command line parameter Vivek Goyal
2006-06-23 21:04 ` [RFC] [PATCH 2/2] kdump: cciss driver initialization issue fix Vivek Goyal
2006-06-24  6:55   ` Andrew Morton
2006-06-24 11:19     ` Vivek Goyal
2006-06-24 11:30       ` Andrew Morton
2006-06-24 12:08         ` Vivek Goyal
2006-06-24 17:13           ` Eric W. Biederman
2006-06-26  2:11             ` [Fastboot] " Maneesh Soni
2006-06-26 13:35               ` Vivek Goyal
2006-06-26 14:17                 ` Eric W. Biederman
2006-06-26 15:32                   ` [Fastboot] " Vivek Goyal
2006-06-26 16:00                     ` Eric W. Biederman
2006-06-26 16:13                       ` Miller, Mike (OS Dev)
2006-06-26 16:35                         ` Vivek Goyal
2006-06-26 16:38                         ` [Fastboot] " Eric W. Biederman
2006-06-26 16:51                           ` Miller, Mike (OS Dev)
2006-06-26 17:04                             ` Vivek Goyal
2006-06-26 17:24                               ` Andrew Morton
2006-06-26 17:22                             ` [Fastboot] " Vivek Goyal
2006-06-26 17:52                             ` Eric W. Biederman
2006-06-26 18:18                               ` Vivek Goyal
2006-06-26 18:51                               ` [Fastboot] " Miller, Mike (OS Dev)
2006-06-26 19:21                                 ` Eric W. Biederman
2006-06-26 19:43                                   ` Vivek Goyal
2006-06-26 21:24                                   ` [Fastboot] " Miller, Mike (OS Dev)
2006-06-26 19:36                                 ` Vivek Goyal
2006-06-26 17:16                       ` Vivek Goyal
2006-06-26 17:31                         ` Andrew Morton [this message]
2006-06-26 17:39                         ` Eric W. Biederman
2006-06-26 17:56                           ` James Bottomley
2006-06-26 18:23                             ` Eric W. Biederman
2006-06-27  2:42                   ` [RFC] [PATCH 2/2] kdump: cciss driver initialization?issue fix Horms
2006-06-26  9:09             ` Horms
2006-06-26 13:45               ` [Fastboot] " Vivek Goyal
2006-06-27  2:30                 ` Horms
     [not found] ` <E1FttEj-0002JH-00@calista.eckenfels.net>
2006-06-23 22:39   ` [RFC] [PATCH 1/2] introduce crashboot kernel command line parameter Vivek Goyal
2006-06-24  6:55 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626103130.de79fd9f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Neela.Kolli@engenio.com \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox