From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: Kai.Makisara@kolumbus.fi
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] st: remove unused st_buffer.in_use
Date: Wed, 28 Jun 2006 15:40:36 +0100 [thread overview]
Message-ID: <20060628144036.GC31139@palantir8> (raw)
Hi,
I noticed that in_use in st_buffer is not used. The patch below
against 2.6.17-rc3 removes it, assuming there is no future use for it.
It was tested in a sparc SS20 with a DLT4000.
Please CC me as I'm not subscribed to the list.
Thanks,
Martin
Signed-off-by: Martin Habets <errandir_news@mph.eclipse.co.uk>
---
--- 2.6.17-rc3/drivers/scsi/st.h.orig 2006-05-01 10:30:53.000000000 +0100
+++ 2.6.17-rc3/drivers/scsi/st.h 2006-06-28 15:17:11.000000000 +0100
@@ -31,7 +31,6 @@
/* The tape buffer descriptor. */
struct st_buffer {
- unsigned char in_use;
unsigned char dma; /* DMA-able buffer */
unsigned char do_dio; /* direct i/o set up? */
int buffer_size;
--- 2.6.17-rc3/drivers/scsi/st.c.orig 2006-05-01 11:04:24.000000000 +0100
+++ 2.6.17-rc3/drivers/scsi/st.c 2006-06-28 15:17:57.000000000 +0100
@@ -3599,7 +3599,6 @@
tb->use_sg = max_sg;
tb->frp = (struct st_buf_fragment *)(&(tb->sg[0]) + max_sg);
- tb->in_use = 1;
tb->dma = need_dma;
tb->buffer_size = got;
next reply other threads:[~2006-06-28 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 14:40 Martin Habets [this message]
2006-06-28 20:02 ` [PATCH] st: remove unused st_buffer.in_use Kai Mäkisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628144036.GC31139@palantir8 \
--to=errandir_news@mph.eclipse.co.uk \
--cc=Kai.Makisara@kolumbus.fi \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox