[PATCH] st: remove unused st_buffer.in_use

[PATCH] st: remove unused st_buffer.in_use

[Martin Habets]

Hi,

I noticed that in_use in st_buffer is not used. The patch below
against 2.6.17-rc3 removes it, assuming there is no future use for it.
It was tested in a sparc SS20 with a DLT4000.

Please CC me as I'm not subscribed to the list.

Thanks,
Martin

	Signed-off-by: Martin Habets <errandir_news@mph.eclipse.co.uk>
---
--- 2.6.17-rc3/drivers/scsi/st.h.orig	2006-05-01 10:30:53.000000000 +0100
+++ 2.6.17-rc3/drivers/scsi/st.h	2006-06-28 15:17:11.000000000 +0100
@@ -31,7 +31,6 @@
 
 /* The tape buffer descriptor. */
 struct st_buffer {
-	unsigned char in_use;
 	unsigned char dma;	/* DMA-able buffer */
 	unsigned char do_dio;   /* direct i/o set up? */
 	int buffer_size;
--- 2.6.17-rc3/drivers/scsi/st.c.orig	2006-05-01 11:04:24.000000000 +0100
+++ 2.6.17-rc3/drivers/scsi/st.c	2006-06-28 15:17:57.000000000 +0100
@@ -3599,7 +3599,6 @@
 	tb->use_sg = max_sg;
 	tb->frp = (struct st_buf_fragment *)(&(tb->sg[0]) + max_sg);
 
-	tb->in_use = 1;
 	tb->dma = need_dma;
 	tb->buffer_size = got;
 

Re: [PATCH] st: remove unused st_buffer.in_use

[Kai Mäkisara]

Martin Habets wrote:
> Hi,
>
> I noticed that in_use in st_buffer is not used. The patch below
> against 2.6.17-rc3 removes it, assuming there is no future use for it.
> It was tested in a sparc SS20 with a DLT4000.
>
>   
This is a remainder from the times when the buffers were shared if the 
number of drives was large. Thanks for noticing this dead code.
> Please CC me as I'm not subscribed to the list.
>
> Thanks,
> Martin
>
> 	Signed-off-by: Martin Habets <errandir_news@mph.eclipse.co.uk>
>   
Acked-by: kai.makisara@kolumbus.fi
> ---
> --- 2.6.17-rc3/drivers/scsi/st.h.orig	2006-05-01 10:30:53.000000000 +0100
> +++ 2.6.17-rc3/drivers/scsi/st.h	2006-06-28 15:17:11.000000000 +0100
> @@ -31,7 +31,6 @@
>  
>  /* The tape buffer descriptor. */
>  struct st_buffer {
> -	unsigned char in_use;
>  	unsigned char dma;	/* DMA-able buffer */
>  	unsigned char do_dio;   /* direct i/o set up? */
>  	int buffer_size;
> --- 2.6.17-rc3/drivers/scsi/st.c.orig	2006-05-01 11:04:24.000000000 +0100
> +++ 2.6.17-rc3/drivers/scsi/st.c	2006-06-28 15:17:57.000000000 +0100
> @@ -3599,7 +3599,6 @@
>  	tb->use_sg = max_sg;
>  	tb->frp = (struct st_buf_fragment *)(&(tb->sg[0]) + max_sg);
>  
> -	tb->in_use = 1;
>  	tb->dma = need_dma;
>  	tb->buffer_size = got;
>  
>