From: Andrew Morton <akpm@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Neela.Kolli@engenio.com, wharms@bfs.de,
linux-scsi@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] megaraid: fix warnings when CONFIG_PROC_FS=n
Date: Thu, 6 Jul 2006 15:30:12 -0700 [thread overview]
Message-ID: <20060706153012.53436336.akpm@osdl.org> (raw)
In-Reply-To: <20060706221950.GA7502@martell.zuzino.mipt.ru>
Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> On Thu, Jul 06, 2006 at 03:10:33PM -0700, Andrew Morton wrote:
> > Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > >
> > > +#else
> > > +static inline void mega_create_proc_entry(int index, struct proc_dir_entry *parent)
> > > +{
> > > +}
> >
> > Thanks. But this is already fixed in -mm. Was submitted to James 25 June
> > and 30 June and is on autorepeat.
>
> drivers-scsi-megaraidc-add-a-dummy-mega_create_proc_entry-for-proc_fs\=y.patch
>
> from Adrian?
Yes, that.
> This patch also fixes all other PROC=n warnings not just adds dummy function.
Well I still don't know what the patch does really - I'd need to compile
the driver with PROC_FS=n to find out.
In future for all warning and build error patches please include the
compiler stderr in the changelog, thanks.
prev parent reply other threads:[~2006-07-06 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 14:23 [PATCH] megaraid: fix warnings when CONFIG_PROC_FS=n Alexey Dobriyan
2006-07-06 22:10 ` Andrew Morton
2006-07-06 22:19 ` Alexey Dobriyan
2006-07-06 22:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060706153012.53436336.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Neela.Kolli@engenio.com \
--cc=adobriyan@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-scsi@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox