public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stephan Seidl <stephan.seidl@tu-dresden.de>, linux-scsi@vger.kernel.org
Subject: Re: broken reverse_scan in aic7xxx
Date: Sat, 8 Jul 2006 19:29:25 -0600	[thread overview]
Message-ID: <20060709012925.GH1605@parisc-linux.org> (raw)
In-Reply-To: <20060708183752.GF1605@parisc-linux.org>

On Sat, Jul 08, 2006 at 12:37:52PM -0600, Matthew Wilcox wrote:
> On Sat, Jul 08, 2006 at 06:48:44PM +0100, Christoph Hellwig wrote:
> > Or you could submit a patch to implement a reverse scanning option in
> > the core PCI code..
> 
> You'd want to specify that on a per-driver basis, though, surely.  Or
> all your ethernet cards would get reversed too.  Oh, but it wouldn't be
> enough for sym2 (iterate through card types instead of through pci ids),
> so you'd want another option for that.

Actually, it's even worse.  PCI doesn't do its own matching any more;
it's now part of the driver core ... so the flag/alternate
implementation has to go all through the callchain:

pci_register_driver
  __pci_register_driver
    driver_register
      bus_add_driver
        driver_attach

At this point, you'd want to change/replace the bus_for_each_dev()
macro.  Wouldn't be too hard to have a bus_for_each_dev_rev() to give
aic7xxx backward compatibility, but sym2 is completely SOL.  The real
pain is passing the information that we want to do this in reverse
all the way down the call chain.

  reply	other threads:[~2006-07-09  1:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-08 15:21 broken reverse_scan in aic7xxx Stephan Seidl
2006-07-08 15:44 ` Matthew Wilcox
2006-07-08 17:48   ` Christoph Hellwig
2006-07-08 18:37     ` Matthew Wilcox
2006-07-09  1:29       ` Matthew Wilcox [this message]
2006-07-09  8:44       ` Arjan van de Ven
2006-07-09 12:19         ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060709012925.GH1605@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stephan.seidl@tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox