Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc

Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc

[Rolf Eike Beer]

Added linux-scsi to CC as it touches drivers/scsi/

>  	/* stuff a sense request in front of our current request */
> -	pc = kmalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> +	pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);

Please remove the space before the arguments.

>  	rq = kmalloc (sizeof (struct request), GFP_ATOMIC);

This and the one before should be "rq = kzalloc(sizeof(*rq),...);" This way 
you will always get the correct buffer size even if the type of rq changes.

Eike