* Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc
[not found] <20060719013113.GF30823@lumumba.uhasselt.be>
@ 2006-07-19 6:23 ` Rolf Eike Beer
0 siblings, 0 replies; only message in thread
From: Rolf Eike Beer @ 2006-07-19 6:23 UTC (permalink / raw)
To: Panagiotis Issaris, linux-scsi; +Cc: linux-kernel, linux-eata
Added linux-scsi to CC as it touches drivers/scsi/
> /* stuff a sense request in front of our current request */
> - pc = kmalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> + pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
Please remove the space before the arguments.
> rq = kmalloc (sizeof (struct request), GFP_ATOMIC);
This and the one before should be "rq = kzalloc(sizeof(*rq),...);" This way
you will always get the correct buffer size even if the type of rq changes.
Eike
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-07-19 6:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060719013113.GF30823@lumumba.uhasselt.be>
2006-07-19 6:23 ` [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc Rolf Eike Beer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox