From: Jens Axboe <axboe@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-scsi@vger.kernel.org, torvalds@osdl.org
Subject: Re: cd burning with plextor drives.
Date: Sat, 29 Jul 2006 13:12:40 +0200 [thread overview]
Message-ID: <20060729111240.GG13095@suse.de> (raw)
In-Reply-To: <20060729045249.GA23398@redhat.com>
On Sat, Jul 29 2006, Dave Jones wrote:
> AFAICT, this has been broken since the code to sanitise scsi commands
> was added circa 2.6.8 or so.
>
> It seems cdrecord tries to send some vendor specific commands to Plextor
> drives, and fails miserably as can be seen here..
> https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=124267
>
> I'm not that familiar with this code, but would adding exceptions
> on a per-vendor basis in sg_allow_access() be the way forward here?
>
> If not, what is the right answer ?
I'd greatly prefer just ripping the entire command access table out, it
was a mistake to begin with and still just a horrible solution.
In fact, I think we should decide soon what to do about it. At the
storage summit, there was general consensus on just killing it as well.
--
Jens Axboe
next prev parent reply other threads:[~2006-07-29 11:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 4:52 cd burning with plextor drives Dave Jones
2006-07-29 11:12 ` Jens Axboe [this message]
2006-07-29 13:40 ` James Bottomley
2006-07-29 15:39 ` Christer Weinigel
2006-07-29 17:06 ` Linus Torvalds
2006-07-29 17:30 ` James Bottomley
2006-07-29 17:49 ` Linus Torvalds
2006-07-30 16:02 ` Christer Weinigel
2006-07-30 19:57 ` Linus Torvalds
2006-07-30 20:18 ` Christian Iversen
2006-07-31 0:12 ` Christer Weinigel
2006-07-31 20:32 ` Linus Torvalds
2006-07-31 20:38 ` Dave Jones
2006-07-31 20:41 ` Jens Axboe
2006-07-31 20:46 ` Linus Torvalds
2006-08-01 6:54 ` Jens Axboe
2006-07-29 18:39 ` Douglas Gilbert
2006-07-29 18:54 ` Linus Torvalds
2006-07-29 20:12 ` Douglas Gilbert
2006-07-29 20:33 ` Linus Torvalds
2006-07-29 20:53 ` Linus Torvalds
2006-07-29 22:13 ` Arjan van de Ven
2006-07-30 5:57 ` Matthew Wilcox
2006-07-30 9:38 ` Rogier Wolff
2006-07-30 18:02 ` Douglas Gilbert
2006-07-30 20:06 ` Linus Torvalds
2006-07-29 21:40 ` Christer Weinigel
2006-07-30 5:56 ` Linus Torvalds
2006-07-29 17:04 ` Linus Torvalds
2006-07-29 17:22 ` Dave Jones
2006-07-30 10:21 ` Rogier Wolff
2006-07-30 10:31 ` Arjan van de Ven
2006-07-30 11:09 ` Steve McIntyre
2006-07-31 9:33 ` Jens Axboe
2006-07-31 9:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060729111240.GG13095@suse.de \
--to=axboe@suse.de \
--cc=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox