From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: James.Smart@emulex.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/6] lpfc 8.1.7 : Adding statistics reset callback for FC transport
Date: Tue, 1 Aug 2006 14:14:51 +0200 [thread overview]
Message-ID: <200608011414.51998.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <1154432009.18162.12.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
James Smart wrote:
> Adding statistics reset callback for FC transport
>
> Signed-off-by: James Smart <James.Smart@emulex.com>
> -/* FIX ME */
> - /*hs->SecondsSinceLastReset = (jiffies - lpfc_loadtime) / HZ;*/
> + hs->seconds_since_last_reset = (jiffies - psli->stats_start) / HZ;
Wraparound?
> +void lpfc_reset_stats(struct Scsi_Host *shost)
> +{
> + struct lpfc_hba *phba = (struct lpfc_hba *)shost->hostdata;
> + struct lpfc_sli *psli = &phba->sli;
> + struct lpfc_lnk_stat * lso = &psli->lnk_stat_offsets;
> + LPFC_MBOXQ_t *pmboxq;
> + MAILBOX_t *pmb;
> + int rc = 0;
> +
> + pmboxq = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
> + if (!pmboxq)
> + return;
> + memset(pmboxq, 0, sizeof (LPFC_MBOXQ_t));
^
No space here.
[...]
> + memset(pmboxq, 0, sizeof (LPFC_MBOXQ_t));
Again.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-08-01 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 11:33 [PATCH 1/6] lpfc 8.1.7 : Adding statistics reset callback for FC transport James Smart
2006-08-01 12:14 ` Rolf Eike Beer [this message]
2006-08-01 13:40 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608011414.51998.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).