From: Matthew Wilcox <matthew@wil.cx>
To: Dave Jones <davej@redhat.com>
Cc: linux-scsi@vger.kernel.org, bobf@advansys.com
Subject: Re: advansys pci tweaks.
Date: Wed, 2 Aug 2006 15:34:20 -0600 [thread overview]
Message-ID: <20060802213420.GG7606@parisc-linux.org> (raw)
In-Reply-To: <20060802211149.GC3639@redhat.com>
On Wed, Aug 02, 2006 at 05:11:49PM -0400, Dave Jones wrote:
> Remove a lot of duplicate #defines from the advansys driver,
> and make them look like PCI IDs as defined elsewhere in the kernel.
> Also add a module table so that it automatically gets picked up
> by tools relying on modinfo output (like say, distro installers).
I'd much rather see at least the vendor ID moved to pci_ids.h; how about
#define PCI_VENDOR_ID_ADVSYS 0x10cd
for that one?
> @@ -889,10 +889,6 @@ typedef unsigned char uchar;
> #define ASC_PCI_ID2DEV(id) (((id) >> 11) & 0x1F)
> #define ASC_PCI_ID2FUNC(id) (((id) >> 8) & 0x7)
> #define ASC_PCI_MKID(bus, dev, func) ((((dev) & 0x1F) << 11) | (((func) & 0x7) << 8) | ((bus) & 0xFF))
... those all need to be fixed too. Sigh. I wonder if Bob Frey is
still around to care about this driver ...
next prev parent reply other threads:[~2006-08-02 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 21:11 advansys pci tweaks Dave Jones
2006-08-02 21:34 ` Matthew Wilcox [this message]
2006-08-02 21:39 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802213420.GG7606@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bobf@advansys.com \
--cc=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox