From: Doug Maxey <dwm@enoyolf.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Ravi Anand <ravi.anand@qlogic.com>,
David Somayajulu <david.somayajulu@qlogic.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Subject: [PATCH ver3 4/4] qla4xxx: improve symmetry in buffer codepaths
Date: Sat, 05 Aug 2006 17:52:38 -0500 [thread overview]
Message-ID: <20060805225237.9557.33531.stgit@bebe.enoyolf.org> (raw)
In-Reply-To: <20060805225156.9557.99072.stgit@bebe.enoyolf.org>
From: Doug Maxey <dwm@enoyolf.org>
In qla4xxx_send_command_to_isp(), pci_map_*() is used. At the other
end, in qla4xxx_srb_free_dma(), dma_unmap_*() is used. Replace the call
with the symmetrical call to pci_unmap_*().
Signed-off-by: Doug Maxey <dwm@enoyolf.org>
---
drivers/scsi/qla4xxx/ql4_os.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index d88c84f..5e10f30 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -382,10 +382,10 @@ static void qla4xxx_srb_free_dma(struct
if (srb->flags & SRB_DMA_VALID) {
if (cmd->use_sg) {
- dma_unmap_sg(&ha->pdev->dev, cmd->request_buffer,
+ pci_unmap_sg(ha->pdev, cmd->request_buffer,
cmd->use_sg, cmd->sc_data_direction);
} else if (cmd->request_bufflen) {
- dma_unmap_single(&ha->pdev->dev, srb->dma_handle,
+ pci_unmap_single(ha->pdev, srb->dma_handle,
cmd->request_bufflen,
cmd->sc_data_direction);
}
prev parent reply other threads:[~2006-08-05 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060805225156.9557.99072.stgit@bebe.enoyolf.org>
2006-08-05 22:52 ` [PATCH ver3 1/4] qla4xxx: Remove funcs with no callers in ql4_init.c Doug Maxey
2006-08-05 22:52 ` [PATCH ver3 2/4] qla4xxx: Add a timeout period and return status from ql4xxx_lock_drvr_wait() Doug Maxey
2006-08-05 22:52 ` [PATCH ver3 3/4] qla4xxx: use dev_xxx on some pci/dma resource alloc warning and error printks Doug Maxey
2006-08-09 17:52 ` Mike Christie
2006-08-09 19:03 ` Doug Maxey
2006-08-09 23:05 ` Doug Maxey
2006-08-09 23:36 ` Ravi Anand
2006-08-10 9:52 ` Mike Christie
2006-08-10 10:18 ` Mike Christie
2006-08-10 13:59 ` James Bottomley
2006-08-05 22:52 ` Doug Maxey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060805225237.9557.33531.stgit@bebe.enoyolf.org \
--to=dwm@enoyolf.org \
--cc=david.somayajulu@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=ravi.anand@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox