Re: [PATCH ver3 3/4] qla4xxx: use dev_xxx on some pci/dma resource alloc warning and error printks

Doug Maxey
2006-08-09T19:08:29Z

On Wed, 09 Aug 2006 13:52:07 EDT, Mike Christie wrote:
...
> > if (ha->srb_mempool == NULL) {
> > - ql4_printk(KERN_WARNING, ha,
> > - "Memory Allocation failed - SRB Pool.\n");
> > -
> > + dev_warn(&ha->pdev->dev,
> > + "Memory Allocation failed - SRB Pool.\n");
> > goto mem_alloc_error_exit;
>
> Sorry for the late response on this one. As you know I was out for a
> while and I was waiting to get internet access yesterday.
>
> For these host messages, do we want something like the sdev_printk and
> starget_printk or does it really make more sense to use the pci bus id
> for the message prefix? What about other scsi host messages, will they
> always go with the pci bus id or some scsi-ml id? And even if we want to
> print out the pci bus id as the prefix instead of some scsi info, should
> we still have some scsi wrapper?
>

Ha. Just pre-replied to the this issue in the patchset just sent.

Will spin up an RFC patch and see where this goes.