From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andreas Herrmann <aherrman@de.ibm.com>,
James Bottomley <jejb@SteelEye.com>,
Linux SCSI <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] limit recursion when flushing shost->starved_list
Date: Mon, 21 Aug 2006 09:04:29 +0200 [thread overview]
Message-ID: <20060821070429.GM4290@suse.de> (raw)
In-Reply-To: <1156019429.3726.18.camel@mulgrave.il.steeleye.com>
On Sat, Aug 19 2006, James Bottomley wrote:
> On Wed, 2006-08-09 at 17:31 +0200, Andreas Herrmann wrote:
> > Attached is a patch that should limit a possible recursion that can
> > lead to a stack overflow like follows:
>
> Well, OK, initially I'll put this in scsi-misc, since I acknowledge its
> a problem. However, it is one that block queue grouping should be able
> to get us out of ... and at that time, this code (and most of the
> starved list handling) should exit the scsi mid-layer.
Yep, the patch is a little nasty but I don't see a better way currently.
So the above outline sounds good to me.
--
Jens Axboe
prev parent reply other threads:[~2006-08-21 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 15:31 [PATCH] limit recursion when flushing shost->starved_list Andreas Herrmann
2006-08-19 20:30 ` James Bottomley
2006-08-21 7:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821070429.GM4290@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=aherrman@de.ibm.com \
--cc=jejb@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox