Re: [PATCH] SCSI: sanitize INQUIRY strings

[Matthew Wilcox <matthew@wil.cx>]

On Mon, Aug 21, 2006 at 12:52:18PM -0400, Alan Stern wrote:
> On Mon, 21 Aug 2006, Matthew Wilcox wrote:
> 
> > On Mon, Aug 21, 2006 at 12:03:21PM -0400, Alan Stern wrote:
> > > This patch (as766) sanitizes the Vendor, Product, and Revision strings
> > > contained in an INQUIRY result, by setting all non-graphic or
> > > non-ASCII characters to ' '.  Since the standard disallows such
> > > characters, this will affect only non-compliant devices.
> > 
> > I thiink you attached the wrong patch; it doesn't match the description
> > at all.
> 
> No; it does match the description.  But you have to read it carefully, 
> because the majority of the patch implements optimizations made possible 
> by the small piece that does the actual sanitizing.

The description should have said that.  I don't know what you're trying
to accomplish with pulling the length byte out of the inquiry data, for
example.

In any case, you didn't address my point that a NUL byte is probably
meant to terminate the string, not merely be treated equivalently to
a space.  Of course, we can do anything here, the device is out of spec,
but in terms of trying to ascertain the intention of the drug-crazed
hobo^W^W^W^W engineer who wrote the firmware, I think your interpretation
is less likely.