qla1280 bugfix in limbo?

qla1280 bugfix in limbo?

[Bailey, Scott]

Just tuning in briefly to report:

1. I have been running my 3-processor Alphaserver 4100 with Ian's patch
http://bugzilla.kernel.org/show_bug.cgi?id=6275 for a little over a
month now, first with 2.6.16 and now with 2.6.17, and it continues to
work like a champ. I very much would like to see this fix incorporated
into the Debian kernel or preferably upstream, since my DLT drive is
pretty much useless without it.

2. Unfortunately, I see no sign that anybody has looked at the kernel
bugzilla report above.

Is there anything I can do to help move things along?

Thanks,

Scott Bailey
scott.bailey@eds.com

Re: Bug#366730: qla1280 bugfix in limbo?

[Thiemo Seufer]

Bailey, Scott wrote:
> Just tuning in briefly to report:
> 
> 1. I have been running my 3-processor Alphaserver 4100 with Ian's patch
> http://bugzilla.kernel.org/show_bug.cgi?id=6275 for a little over a
> month now, first with 2.6.16 and now with 2.6.17, and it continues to
> work like a champ. I very much would like to see this fix incorporated
> into the Debian kernel or preferably upstream, since my DLT drive is
> pretty much useless without it.
> 
> 2. Unfortunately, I see no sign that anybody has looked at the kernel
> bugzilla report above.
> 
> Is there anything I can do to help move things along?

Send the patch with description and Signed-Off-By: line to
linux-scsi@vger.kernel.org.


Thiemo

[SCSI] - eliminate hard-coded timeouts in qla1280.c

[Bailey, Scott]

Thanks are due to Ian Dall for the following patch. It replaces
hard-coded
30-second timeouts in qla1280.c, enabling tape operations that take
longer
than 30 seconds to work again. :-)

This patch applies cleanly to 2.6.17.11 with an offset of 1 line.

Signed-off-by: R. Scott Bailey <scott.bailey@eds.com>

--- qla1280.c	2006-03-20 16:23:29.000000000 +1030
+++ qla1280.c	2006-03-23 23:37:28.000000000 +1030
@@ -2886,7 +2886,7 @@
 	memset(((char *)pkt + 8), 0, (REQUEST_ENTRY_SIZE - 8));
 
 	/* Set ISP command timeout. */
-	pkt->timeout = cpu_to_le16(30);
+	pkt->timeout = cpu_to_le16(cmd->timeout_per_command/HZ);
 
 	/* Set device target ID and LUN */
 	pkt->lun = SCSI_LUN_32(cmd);
@@ -3185,7 +3185,7 @@
 	memset(((char *)pkt + 8), 0, (REQUEST_ENTRY_SIZE - 8));
 
 	/* Set ISP command timeout. */
-	pkt->timeout = cpu_to_le16(30);
+	pkt->timeout = cpu_to_le16(cmd->timeout_per_command/HZ);
 
 	/* Set device target ID and LUN */
 	pkt->lun = SCSI_LUN_32(cmd);

Re: qla1280 bugfix in limbo?

[Jes Sorensen]

>>>>> "Scott" == Bailey, Scott <scott.bailey@eds.com> writes:

Scott> Just tuning in briefly to report: 1. I have been running my
Scott> 3-processor Alphaserver 4100 with Ian's patch
Scott> http://bugzilla.kernel.org/show_bug.cgi?id=6275 for a little
Scott> over a month now, first with 2.6.16 and now with 2.6.17, and it
Scott> continues to work like a champ. I very much would like to see
Scott> this fix incorporated into the Debian kernel or preferably
Scott> upstream, since my DLT drive is pretty much useless without it.

Scott> 2. Unfortunately, I see no sign that anybody has looked at the
Scott> kernel bugzilla report above.

The problem is that the person who submitted it didn't bother CC'ing
the driver maintainer so nobody was aware of the bug being in
bugzilla.

I just discovered it today and I just plan to test it before I push it
upstream.

Jes