From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
"Moore, Eric" <Eric.Moore@lsil.com>
Subject: Re: [PATCH] scsi_transport_sas: remove local_attached flag
Date: Mon, 28 Aug 2006 10:30:12 +0100 [thread overview]
Message-ID: <20060828093012.GB8980@infradead.org> (raw)
In-Reply-To: <1156531698.3462.11.camel@mulgrave.il.steeleye.com>
On Fri, Aug 25, 2006 at 01:48:18PM -0500, James Bottomley wrote:
> This flag denotes local attachment of the phy. There are two problems
> with it:
>
> 1) It's actually redundant ... you can get the same information simply
> by seeing whether a host is the phys parent
> 2) we condition a lot of phy parameters on it on the false assumption
> that we can only control local phys. I'm wiring up phy resets in the
> aic94xx now, and it will be able to reset non-local phys as well.
>
> I fixed 2) by moving the local check into the reset and stats function
> of the mptsas, since that seems to be the only HBA that can't
> (currently) control non-local phys.
You can of course do the reset and stats using the normal smp code from
libsas for fusion aswell. I just added the flag as a quick hack because
I was waiting for the libsas merge to implement this instead of adding
a mptsas-specific implementation.
next prev parent reply other threads:[~2006-08-28 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 18:48 [PATCH] scsi_transport_sas: remove local_attached flag James Bottomley
2006-08-28 9:30 ` Christoph Hellwig [this message]
2006-08-28 14:01 ` James Bottomley
2006-08-29 11:47 ` Christoph Hellwig
2006-08-28 14:19 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2006-08-29 15:24 Moore, Eric
2006-08-29 15:35 ` James Bottomley
2006-08-29 16:03 Moore, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060828093012.GB8980@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox