From: Jens Axboe <axboe@kernel.dk>
To: Ed Lin <ed.lin@promise.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] block: add support for shared tag maps
Date: Thu, 31 Aug 2006 11:00:14 +0200 [thread overview]
Message-ID: <20060831090014.GA5528@kernel.dk> (raw)
In-Reply-To: <NONAMEBU6CuyzC0bHwr00000ed4@nonameb.ptu.promise.com>
On Thu, Aug 31 2006, Ed Lin wrote:
>
> ======= On 2006-08-30 21:44:18, James Bottomley wrote:
> >+
> >+/**
> >+ * blk_free_tags - release a given set of tag maintenance info
> >+ *
> >+ * @bqt: the tag map to free
> >+ *
> >+ * For externally managed @bqt@ frees the map. Callers of this
> >+ * function must guarantee to have released all the queues that
> >+ * might have been using this tag map.
> >+ */
> >+void blk_free_tags(struct blk_queue_tag *bqt)
> >+{
> >+ if (unlikely(!__blk_free_tags(bqt)))
> >+ BUG();
> >+}
> >+
>
> EXPORT_SYMBOL(blk_free_tags) ?
> Also, add new function definitions in blkdev.h?
Good point. James will be reposting it anyways, the patch needed a few
more fixes (memory leak, coding style).
--
Jens Axboe
next prev parent reply other threads:[~2006-08-31 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 8:55 [PATCH] block: add support for shared tag maps Ed Lin
2006-08-31 9:00 ` Jens Axboe [this message]
2006-08-31 22:21 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2006-09-01 6:31 Ed Lin
2006-09-01 13:28 ` James Bottomley
2006-09-01 19:04 ` Doug Maxey
2006-09-01 20:11 ` Mike Anderson
2006-09-01 20:21 ` Ravi Anand
2006-09-01 20:52 ` James Bottomley
2006-09-18 18:47 ` Christoph Hellwig
2006-09-18 19:10 ` James Bottomley
2006-09-18 19:25 ` Mike Christie
2006-09-19 2:20 ` Doug Ledford
2006-08-30 13:44 James Bottomley
2006-08-30 15:31 ` Randy.Dunlap
2006-08-30 15:39 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831090014.GA5528@kernel.dk \
--to=axboe@kernel.dk \
--cc=James.Bottomley@SteelEye.com \
--cc=ed.lin@promise.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox