[PATCH] aic94xx: Fix incorrect memory allocation size

[PATCH] aic94xx: Fix incorrect memory allocation size

[malahal]

This patch corrects the size passed to kmalloc in asd_register_sas_ha()

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>


diff -r 134012c83658 drivers/scsi/aic94xx/aic94xx_init.c
--- a/drivers/scsi/aic94xx/aic94xx_init.c	Thu Aug 31 13:03:38 2006 -0700
+++ b/drivers/scsi/aic94xx/aic94xx_init.c	Wed Sep 06 23:40:29 2006 -0700
@@ -481,9 +481,9 @@ static int asd_register_sas_ha(struct as
 {
 	int i;
 	struct asd_sas_phy   **sas_phys =
-		kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_phy), GFP_KERNEL);
+		kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_phy *), GFP_KERNEL);
 	struct asd_sas_port  **sas_ports =
-		kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_port), GFP_KERNEL);
+		kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_port *), GFP_KERNEL);
 
 	if (!sas_phys || !sas_ports) {
 		kfree(sas_phys);

Re: [PATCH] aic94xx: Fix incorrect memory allocation size

[James Bottomley]

On Thu, 2006-09-07 at 11:39 -0700, malahal@us.ibm.com wrote:
> This patch corrects the size passed to kmalloc in asd_register_sas_ha()

Actually, could you fix this properly?  It should be in the scsi host
structure or something related so its lifetime is that of the SCSI host,
then we don't need to worry about tracking it.  The kmalloc was only a
first approximation hack to get the driver to work with multiple
controllers.

Thanks,

James