From: Christoph Hellwig <hch@infradead.org>
To: Ed Lin <ed.lin@promise.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] block: add support for shared tag maps
Date: Mon, 18 Sep 2006 19:47:12 +0100 [thread overview]
Message-ID: <20060918184712.GA17670@infradead.org> (raw)
In-Reply-To: <NONAMEBh8GyUbvH4KQ700000f3d@nonameb.ptu.promise.com>
On Fri, Sep 01, 2006 at 02:31:51PM +0800, Ed Lin wrote:
> static int
> +stex_slave_alloc(struct scsi_device *sdev)
> +{
> + /* Cheat: usually extracted from Inquiry data */
> + sdev->tagged_supported = 1;
> +
> + scsi_activate_tcq(sdev, sdev->host->can_queue);
these two calls look wrong here. scsi_activate_tcq is supposed to be
called from slave_configure. similarly tagged_supported is probably
going to be overwriten as part of the scanning process, but you already
set it in slave_configure anyway.
> + tag = cmd->request->tag;
> +
> + if (unlikely(tag >= host->can_queue))
> return SCSI_MLQUEUE_HOST_BUSY;
Do we really need this check? I'm pretty sure the block layer never
hands out tags bigger than what you told it to with scsi_activate_tcq.
next prev parent reply other threads:[~2006-09-18 18:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 6:31 [PATCH] block: add support for shared tag maps Ed Lin
2006-09-01 13:28 ` James Bottomley
2006-09-01 19:04 ` Doug Maxey
2006-09-01 20:11 ` Mike Anderson
2006-09-01 20:21 ` Ravi Anand
2006-09-01 20:52 ` James Bottomley
2006-09-18 18:47 ` Christoph Hellwig [this message]
2006-09-18 19:10 ` James Bottomley
2006-09-18 19:25 ` Mike Christie
2006-09-19 2:20 ` Doug Ledford
-- strict thread matches above, loose matches on Subject: below --
2006-08-31 8:55 Ed Lin
2006-08-31 9:00 ` Jens Axboe
2006-08-31 22:21 ` James Bottomley
2006-08-30 13:44 James Bottomley
2006-08-30 15:31 ` Randy.Dunlap
2006-08-30 15:39 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918184712.GA17670@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=ed.lin@promise.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox