public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures
Date: Mon, 18 Sep 2006 20:01:55 +0100	[thread overview]
Message-ID: <20060918190155.GE17670@infradead.org> (raw)
In-Reply-To: <1158330872.29932.61.camel@localhost.localdomain>

On Fri, Sep 15, 2006 at 03:34:32PM +0100, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c
> --- linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c	2006-09-11 17:00:17.000000000 +0100
> +++ linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c	2006-09-14 16:50:25.000000000 +0100
> @@ -9194,7 +9194,7 @@
>      for (i = 0; i < ARRAY_SIZE(aic_pdevs); i++)
>      {
>        pdev = NULL;
> -      while ((pdev = pci_find_device(aic_pdevs[i].vendor_id,
> +      while ((pdev = pci_get_device(aic_pdevs[i].vendor_id,
>                                       aic_pdevs[i].device_id,

NACK.  This doesn't help us forward at all.  In case you have
the hardware please do a full conversion to the real pci probing API.


  reply	other threads:[~2006-09-18 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15 14:34 [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures Alan Cox
2006-09-18 19:01 ` Christoph Hellwig [this message]
2006-09-18 19:45   ` Alan Cox
2006-09-19  2:10   ` Doug Ledford
2006-09-19  8:32   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060918190155.GE17670@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox