* [PATCH] aic94xx: Compile problem on s390
@ 2006-09-18 19:15 Konrad Rzeszutek
2006-09-18 19:21 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Rzeszutek @ 2006-09-18 19:15 UTC (permalink / raw)
To: linux-scsi; +Cc: linux-kernel, alexisb
The aic94xx driver in my-scsi and aic94xx James Bottomley tree does not
compile on s390. Since the driver is generic, it makes sense to fix.
The patch is quite simple:
diff -uNr linux-2.6.17.noarch.orig/include/scsi/libsas.h linux-2.6.17.noarch/include/scsi/libsas.h
--- linux-2.6.17.noarch.orig/include/scsi/libsas.h 2006-09-11 16:29:48.000000000 -0400
+++ linux-2.6.17.noarch/include/scsi/libsas.h 2006-09-11 16:34:33.000000000 -0400
@@ -32,6 +32,7 @@
#include <scsi/sas.h>
#include <linux/list.h>
#include <asm/semaphore.h>
+#include <asm/scatterlist.h>
#include <scsi/scsi_device.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_transport_sas.h>
--
Konrad Rzeszutek 1-(978)-392-3903 or 1-(617)-693-1718
IBM on-site partner.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aic94xx: Compile problem on s390
2006-09-18 19:15 [PATCH] aic94xx: Compile problem on s390 Konrad Rzeszutek
@ 2006-09-18 19:21 ` Matthew Wilcox
2006-09-18 19:36 ` Konrad Rzeszutek
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2006-09-18 19:21 UTC (permalink / raw)
To: Konrad Rzeszutek; +Cc: linux-scsi, linux-kernel, alexisb
On Mon, Sep 18, 2006 at 03:15:45PM -0400, Konrad Rzeszutek wrote:
> The aic94xx driver in my-scsi and aic94xx James Bottomley tree does not
> compile on s390. Since the driver is generic, it makes sense to fix.
Erm, well, I don't think there's any s390s with PCI ;-)
> The patch is quite simple:
> +#include <asm/scatterlist.h>
Surely should be linux/scatterlist.h?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aic94xx: Compile problem on s390
2006-09-18 19:21 ` Matthew Wilcox
@ 2006-09-18 19:36 ` Konrad Rzeszutek
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek @ 2006-09-18 19:36 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-scsi, linux-kernel, alexisb
On Mon, Sep 18, 2006 at 01:21:38PM -0600, Matthew Wilcox wrote:
> On Mon, Sep 18, 2006 at 03:15:45PM -0400, Konrad Rzeszutek wrote:
> > The aic94xx driver in my-scsi and aic94xx James Bottomley tree does not
> > compile on s390. Since the driver is generic, it makes sense to fix.
>
> Erm, well, I don't think there's any s390s with PCI ;-)
>
> > The patch is quite simple:
> > +#include <asm/scatterlist.h>
>
> Surely should be linux/scatterlist.h?
Hm. Most of the drivers use the <asm/...> and that is where
the struct scatterlist is defined. The linux/scatterlist.h includes
the asm/scatterlist.h.
Either one works.
--
Konrad Rzeszutek 1-(978)-392-3903 or 1-(617)-693-1718
IBM on-site partner.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-18 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-18 19:15 [PATCH] aic94xx: Compile problem on s390 Konrad Rzeszutek
2006-09-18 19:21 ` Matthew Wilcox
2006-09-18 19:36 ` Konrad Rzeszutek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox