From: linas@austin.ibm.com (Linas Vepstas)
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Luca <kronos.it@gmail.com>,
linux-scsi@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver
Date: Fri, 22 Sep 2006 18:50:17 -0500 [thread overview]
Message-ID: <20060922235017.GD14213@austin.ibm.com> (raw)
In-Reply-To: <20060922163929.bb870ee1.rdunlap@xenotime.net>
On Fri, Sep 22, 2006 at 04:39:29PM -0700, Randy.Dunlap wrote:
> On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:
>
> > On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:
> > >
> > > Space after function name? You put in other places too, it's not
> > > consistent with the rest of the patch.
> >
> > Oops. I was also coding on a different project recently, with a
> > different style. I'll send a revised patch in a moment.
>
> Please change if()'s to use
>
> if (var == constant)
> instead of
> if (constant == var)
Yuck! Horrid coding style! No rational excuse for coding like that.
Advice taken under protest; new patch shortly.
--linas
next prev parent reply other threads:[~2006-09-22 23:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 23:13 [PATCH]: PCI Error Recovery: Symbios SCSI device driver Linas Vepstas
2006-09-22 22:06 ` Luca
2006-09-22 23:32 ` Linas Vepstas
2006-09-22 23:39 ` Randy.Dunlap
2006-09-22 23:50 ` Linas Vepstas [this message]
2006-09-23 0:57 ` Randy.Dunlap
2006-09-22 23:55 ` [PATCH]: (revised 2) " Linas Vepstas
2006-09-22 23:43 ` [PATCH]: (revised) " Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2007-07-02 18:39 [PATCH]: " Linas Vepstas
2007-07-05 18:28 ` Andrew Morton
2007-07-05 18:54 ` Matthew Wilcox
2007-08-02 22:53 ` Linas Vepstas
2006-10-20 18:05 Linas Vepstas
2006-10-31 18:55 ` Matthew Wilcox
2006-10-31 19:24 ` James Bottomley
2006-10-31 22:26 ` Linas Vepstas
2006-10-31 23:13 ` Linas Vepstas
2006-11-02 4:46 ` Grant Grundler
2006-11-02 4:56 ` Matthew Wilcox
2006-02-02 20:15 [PATCH] " Linas Vepstas
2006-01-18 16:53 linas
2006-01-18 17:07 ` Matthew Wilcox
2006-01-18 17:54 ` linas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060922235017.GD14213@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).