From: Matthew Wilcox <matthew@wil.cx>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] async scsi scanning, version 11
Date: Sun, 24 Sep 2006 14:40:01 -0600 [thread overview]
Message-ID: <20060924204000.GE2595@parisc-linux.org> (raw)
In-Reply-To: <20060924130253.48f90fe5.rdunlap@xenotime.net>
On Sun, Sep 24, 2006 at 01:02:53PM -0700, Randy Dunlap wrote:
> Do parts of Documentation/scsi/scsi_low_mid_api.txt need to be
> updated also?
> or are all of these changes outside of the low_mid realm?
There's no interface changes at this point. Once we start to get into
fixing the FC/SAS drivers, there'll be some documenting to be done.
> > +struct async_scan_data * scsi_prep_async_scan(struct Scsi_Host *shost)
>
> whitespace violation (*scsi_prep_async_scan)
Hmm? Wouldn't that be a function pointer? Did you mean to say I should
use:
struct async_scan_data *scsi_prep_async_scan(struct Scsi_Host *shost)
? I don't particularly mind either way.
> and thanks for adding/using kernel-doc.
I like it. Documenting an earlier version of the interface made me
realise it had bad semantics, so I fixed it rather than try to document
its quirks.
next prev parent reply other threads:[~2006-09-24 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-24 19:06 [PATCH] async scsi scanning, version 11 Matthew Wilcox
2006-09-24 19:43 ` Dave Jones
2006-09-24 19:51 ` Matthew Wilcox
2006-09-24 20:02 ` Randy Dunlap
2006-09-24 20:40 ` Matthew Wilcox [this message]
2006-09-24 20:42 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060924204000.GE2595@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox