From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jeff@garzik.org>,
linux-scsi@vger.kernel.org, Greg KH <greg@kroah.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Illustration of warning explosion silliness
Date: Wed, 27 Sep 2006 21:44:28 -0700 [thread overview]
Message-ID: <20060927214428.9e5c0e79.akpm@osdl.org> (raw)
In-Reply-To: <20060927213628.ef12b1ed.akpm@osdl.org>
On Wed, 27 Sep 2006 21:36:28 -0700
Andrew Morton <akpm@osdl.org> wrote:
> device_for_each_child()
All that being said, device_for_each_child() is rather broken by design.
It walks a list of items applying a function to them and bales out on
first-error.
There's no way in which the caller can know which items have been operated
on, nor which items have yet to be operated on, nor which item experienced
the failure. Any caller which is serious about error recovery presumably
won't use it, unless the callback function happens to be something which
makes no state changes.
next prev parent reply other threads:[~2006-09-28 4:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 0:58 [PATCH] Illustration of warning explosion silliness Jeff Garzik
2006-09-28 1:35 ` Andrew Morton
2006-09-28 1:48 ` Jeff Garzik
2006-09-28 3:34 ` Andrew Morton
2006-09-28 4:19 ` Jeff Garzik
2006-09-28 4:36 ` Andrew Morton
2006-09-28 4:42 ` Jeff Garzik
2006-09-28 4:47 ` Andrew Morton
2006-09-28 4:44 ` Andrew Morton [this message]
2006-09-28 4:54 ` Jeff Garzik
2006-09-28 5:04 ` Andrew Morton
2006-09-28 23:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060927214428.9e5c0e79.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox