From: Matthew Wilcox <matthew@wil.cx>
To: Frederik Deweerdt <deweerdt@free.fr>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-scsi@vger.kernel.org,
"Linux-Kernel," <linux-kernel@vger.kernel.org>,
"J.A. Magall??n" <jamagallon@ono.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>, Jeff Garzik <jeff@garzik.org>
Subject: Re: [RFC PATCH] move aic7xxx to pci_request_irq
Date: Mon, 2 Oct 2006 12:27:44 -0600 [thread overview]
Message-ID: <20061002182744.GM16272@parisc-linux.org> (raw)
In-Reply-To: <20061002200703.GD3003@slug>
On Mon, Oct 02, 2006 at 08:07:03PM +0000, Frederik Deweerdt wrote:
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c
> @@ -341,12 +341,12 @@ ahd_pci_map_int(struct ahd_softc *ahd)
> {
> int error;
>
> - error = request_irq(ahd->dev_softc->irq, ahd_linux_isr,
> - IRQF_SHARED, "aic79xx", ahd);
> + error = pci_request_irq(ahd->dev_softc, ahd_linux_isr,
> + IRQF_SHARED, "aic79xx");
> if (!error)
> ahd->platform_data->irq = ahd->dev_softc->irq;
>
> - return (-error);
> + return error;
Seems unsafe to me. Unless you want to trace through the whole driver
changing its internal conventions to use negative errnos like the rest
of the kernel.
> -
> - return (-error);
> -}
>
> + return error;
> +}
Ditto.
next prev parent reply other threads:[~2006-10-02 18:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060928014623.ccc9b885.akpm@osdl.org>
2006-09-29 13:57 ` 2.6.18-mm2 J.A. Magallón
2006-09-29 14:39 ` 2.6.18-mm2 Matthew Wilcox
2006-09-29 17:15 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:50 ` 2.6.18-mm2 Frederik Deweerdt
2006-09-29 23:43 ` 2.6.18-mm2 Alan Cox
2006-09-30 14:09 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 14:19 ` Alan Cox
2006-09-30 13:51 ` Willy Tarreau
2006-09-30 23:58 ` Jeff Garzik
2006-10-01 14:28 ` Matthew Wilcox
2006-10-01 19:05 ` Arjan van de Ven
2006-10-01 19:19 ` Jeff Garzik
2006-10-01 19:34 ` Arjan van de Ven
2006-10-01 19:36 ` Matthew Wilcox
2006-10-01 19:42 ` Jeff Garzik
2006-10-02 2:12 ` Arjan van de Ven
2006-10-02 20:00 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Frederik Deweerdt
2006-10-02 18:15 ` Matthew Wilcox
2006-10-02 21:09 ` Frederik Deweerdt
2006-10-02 20:07 ` [RFC PATCH] move aic7xxx to pci_request_irq Frederik Deweerdt
2006-10-02 18:27 ` Matthew Wilcox [this message]
2006-10-02 21:02 ` Frederik Deweerdt
2006-10-03 3:45 ` Arjan van de Ven
2006-10-02 20:11 ` [RFC PATCH] move tg3 " Frederik Deweerdt
2006-10-02 18:28 ` Matthew Wilcox
2006-10-02 21:04 ` Frederik Deweerdt
2006-10-03 7:18 ` Arjan van de Ven
2006-10-02 20:12 ` [RFC PATCH] move drm " Frederik Deweerdt
2006-10-02 18:37 ` Matthew Wilcox
2006-10-02 21:07 ` Frederik Deweerdt
2006-10-02 20:36 ` Alan Cox
2006-10-02 22:26 ` Frederik Deweerdt
2006-10-02 23:54 ` Dave Airlie
2006-10-03 7:17 ` Frederik Deweerdt
2006-10-03 3:58 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Randy Dunlap
2006-10-01 21:31 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 15:26 ` 2.6.18-mm2 James Bottomley
2006-09-30 16:21 ` 2.6.18-mm2 Matthew Wilcox
2006-09-30 17:20 ` 2.6.18-mm2 Mark Rustad
2006-09-30 20:54 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:15 ` 2.6.18-mm2 J.A. Magallón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002182744.GM16272@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=deweerdt@free.fr \
--cc=jamagallon@ono.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox