From: Frederik Deweerdt <deweerdt@free.fr>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-scsi@vger.kernel.org,
"Linux-Kernel," <linux-kernel@vger.kernel.org>,
"J.A. Magall??n" <jamagallon@ono.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>, Jeff Garzik <jeff@garzik.org>
Subject: [RFC PATCH] move drm to pci_request_irq
Date: Mon, 2 Oct 2006 20:12:29 +0000 [thread overview]
Message-ID: <20061002201229.GF3003@slug> (raw)
In-Reply-To: <20061002200048.GC3003@slug>
Hi,
This proof-of-concept patch converts the drm driver to use the
pci_request_irq() function.
Regards,
Frederik
diff --git a/drivers/char/drm/drm_drv.c b/drivers/char/drm/drm_drv.c
index b366c5b..5b000cd 100644
--- a/drivers/char/drm/drm_drv.c
+++ b/drivers/char/drm/drm_drv.c
@@ -234,6 +234,8 @@ int drm_lastclose(drm_device_t * dev)
}
mutex_unlock(&dev->struct_mutex);
+ pci_set_drvdata(dev, NULL);
+
DRM_DEBUG("lastclose completed\n");
return 0;
}
diff --git a/drivers/char/drm/drm_irq.c b/drivers/char/drm/drm_irq.c
index 4553a3a..5dd12cb 100644
--- a/drivers/char/drm/drm_irq.c
+++ b/drivers/char/drm/drm_irq.c
@@ -132,8 +132,10 @@ static int drm_irq_install(drm_device_t
if (drm_core_check_feature(dev, DRIVER_IRQ_SHARED))
sh_flags = IRQF_SHARED;
- ret = request_irq(dev->irq, dev->driver->irq_handler,
- sh_flags, dev->devname, dev);
+ pci_set_drvdata(dev->pdev, dev);
+
+ ret = pci_request_irq(dev->pdev, dev->driver->irq_handler,
+ sh_flags, dev->devname);
if (ret < 0) {
mutex_lock(&dev->struct_mutex);
dev->irq_enabled = 0;
@@ -173,7 +175,7 @@ int drm_irq_uninstall(drm_device_t * dev
dev->driver->irq_uninstall(dev);
- free_irq(dev->irq, dev);
+ pci_free_irq(dev->pdev);
return 0;
}
next prev parent reply other threads:[~2006-10-02 18:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060928014623.ccc9b885.akpm@osdl.org>
2006-09-29 13:57 ` 2.6.18-mm2 J.A. Magallón
2006-09-29 14:39 ` 2.6.18-mm2 Matthew Wilcox
2006-09-29 17:15 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:50 ` 2.6.18-mm2 Frederik Deweerdt
2006-09-29 23:43 ` 2.6.18-mm2 Alan Cox
2006-09-30 14:09 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 14:19 ` Alan Cox
2006-09-30 13:51 ` Willy Tarreau
2006-09-30 23:58 ` Jeff Garzik
2006-10-01 14:28 ` Matthew Wilcox
2006-10-01 19:05 ` Arjan van de Ven
2006-10-01 19:19 ` Jeff Garzik
2006-10-01 19:34 ` Arjan van de Ven
2006-10-01 19:36 ` Matthew Wilcox
2006-10-01 19:42 ` Jeff Garzik
2006-10-02 2:12 ` Arjan van de Ven
2006-10-02 20:00 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Frederik Deweerdt
2006-10-02 18:15 ` Matthew Wilcox
2006-10-02 21:09 ` Frederik Deweerdt
2006-10-02 20:07 ` [RFC PATCH] move aic7xxx to pci_request_irq Frederik Deweerdt
2006-10-02 18:27 ` Matthew Wilcox
2006-10-02 21:02 ` Frederik Deweerdt
2006-10-03 3:45 ` Arjan van de Ven
2006-10-02 20:11 ` [RFC PATCH] move tg3 " Frederik Deweerdt
2006-10-02 18:28 ` Matthew Wilcox
2006-10-02 21:04 ` Frederik Deweerdt
2006-10-03 7:18 ` Arjan van de Ven
2006-10-02 20:12 ` Frederik Deweerdt [this message]
2006-10-02 18:37 ` [RFC PATCH] move drm " Matthew Wilcox
2006-10-02 21:07 ` Frederik Deweerdt
2006-10-02 20:36 ` Alan Cox
2006-10-02 22:26 ` Frederik Deweerdt
2006-10-02 23:54 ` Dave Airlie
2006-10-03 7:17 ` Frederik Deweerdt
2006-10-03 3:58 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Randy Dunlap
2006-10-01 21:31 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 15:26 ` 2.6.18-mm2 James Bottomley
2006-09-30 16:21 ` 2.6.18-mm2 Matthew Wilcox
2006-09-30 17:20 ` 2.6.18-mm2 Mark Rustad
2006-09-30 20:54 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:15 ` 2.6.18-mm2 J.A. Magallón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002201229.GF3003@slug \
--to=deweerdt@free.fr \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=jamagallon@ono.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox