* [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value
@ 2006-10-09 13:33 Swen Schillig
2006-10-11 15:05 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Swen Schillig @ 2006-10-09 13:33 UTC (permalink / raw)
To: linux-scsi; +Cc: James Bottomley
commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941
Author: Swen Schillig <swen@vnet.ibm.com>
Date: Mon Oct 9 14:59:08 2006 +0200
Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with
appropriate value.
ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
/* max. number of (data buffer) SBALEs in largest SBAL chain
multiplied with number of sectors per 4k block */
##############################################
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 8f88269..88591a4 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390/scsi/zfcp_def.h
@@ -107,6 +107,10 @@ #define ZFCP_MAX_SBALES_PER_REQ \
(ZFCP_MAX_SBALS_PER_REQ * ZFCP_MAX_SBALES_PER_SBAL - 2)
/* request ID + QTCB in SBALE 0 + 1 of first SBAL in chain */
+#define ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
+ /* max. number of (data buffer) SBALEs in largest SBAL chain
+ multiplied with number of sectors per 4k block */
+
/* FIXME(tune): free space should be one max. SBAL chain plus what? */
#define ZFCP_QDIO_PCI_INTERVAL (QDIO_MAX_BUFFERS_PER_Q \
- (ZFCP_MAX_SBALS_PER_REQ + 4))
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
index 7cafa34..71fee53 100644
--- a/drivers/s390/scsi/zfcp_scsi.c
+++ b/drivers/s390/scsi/zfcp_scsi.c
@@ -58,6 +58,7 @@ struct zfcp_data zfcp_data = {
.cmd_per_lun = 1,
.use_clustering = 1,
.sdev_attrs = zfcp_sysfs_sdev_attrs,
+ .max_sectors = ZFCP_MAX_SECTORS,
},
.driver_version = ZFCP_VERSION,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value
2006-10-09 13:33 [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value Swen Schillig
@ 2006-10-11 15:05 ` James Bottomley
2006-10-12 9:43 ` Swen Schillig
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2006-10-11 15:05 UTC (permalink / raw)
To: Swen Schillig; +Cc: linux-scsi
On Mon, 2006-10-09 at 15:33 +0200, Swen Schillig wrote:
> commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941
> Author: Swen Schillig <swen@vnet.ibm.com>
> Date: Mon Oct 9 14:59:08 2006 +0200
>
> Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with
> appropriate value.
>
> ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
> /* max. number of (data buffer) SBALEs in largest SBAL chain
> multiplied with number of sectors per 4k block */
This needs a signoff.
Plus it doesn't apply: it looks like your mailer has converted tabs to
spaces.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value
2006-10-11 15:05 ` James Bottomley
@ 2006-10-12 9:43 ` Swen Schillig
0 siblings, 0 replies; 3+ messages in thread
From: Swen Schillig @ 2006-10-12 9:43 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
Sorry James
won't happen again.
###############################################
commit 9ceca33ffd6287163e39030f3a5c6fad60d17f7b
Author: Swen Schillig <swen@vnet.ibm.com>
Date: Thu Oct 12 11:24:54 2006 +0200
Define ZFCP_MAX_SECTORS and initialize scsi_host_template.max_sectors
with appropriate value.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 8f88269..74c0eac 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390/scsi/zfcp_def.h
@@ -107,6 +107,10 @@ #define ZFCP_MAX_SBALES_PER_REQ \
(ZFCP_MAX_SBALS_PER_REQ * ZFCP_MAX_SBALES_PER_SBAL - 2)
/* request ID + QTCB in SBALE 0 + 1 of first SBAL in chain */
+#define ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
+ /* max. number of (data buffer) SBALEs in largest SBAL chain
+ multiplied with number of sectors per 4k block */
+
/* FIXME(tune): free space should be one max. SBAL chain plus what? */
#define ZFCP_QDIO_PCI_INTERVAL (QDIO_MAX_BUFFERS_PER_Q \
- (ZFCP_MAX_SBALS_PER_REQ + 4))
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
index 4d2bc79..452d96f 100644
--- a/drivers/s390/scsi/zfcp_scsi.c
+++ b/drivers/s390/scsi/zfcp_scsi.c
@@ -58,6 +58,7 @@ struct zfcp_data zfcp_data = {
.cmd_per_lun = 1,
.use_clustering = 1,
.sdev_attrs = zfcp_sysfs_sdev_attrs,
+ .max_sectors = ZFCP_MAX_SECTORS,
},
.driver_version = ZFCP_VERSION,
};
On Wednesday 11 October 2006 17:05, you wrote:
> On Mon, 2006-10-09 at 15:33 +0200, Swen Schillig wrote:
> > commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941
> > Author: Swen Schillig <swen@vnet.ibm.com>
> > Date: Mon Oct 9 14:59:08 2006 +0200
> >
> > Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with
> > appropriate value.
> >
> > ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
> > /* max. number of (data buffer) SBALEs in largest SBAL chain
> > multiplied with number of sectors per 4k block */
>
> This needs a signoff.
>
> Plus it doesn't apply: it looks like your mailer has converted tabs to
> spaces.
>
> James
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-12 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-09 13:33 [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value Swen Schillig
2006-10-11 15:05 ` James Bottomley
2006-10-12 9:43 ` Swen Schillig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox