Re: [PATCH 3/8] qla2xxx: Add support for system hostname FC transport attribute.

[Christoph Hellwig <hch@infradead.org>]

On Mon, Oct 02, 2006 at 12:00:45PM -0700, Andrew Vasquez wrote:
> The system hostname will be used during a subsequent FDMI registration
> with the fabric.
> 
> Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
> ---
>  drivers/scsi/qla2xxx/qla_attr.c |   10 ++++++++++
>  drivers/scsi/qla2xxx/qla_gs.c   |   15 +++++++++++++++
>  2 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index 4638469..4e1e175 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -857,6 +857,14 @@ qla2x00_get_host_symbolic_name(struct Sc
>  	qla2x00_get_sym_node_name(ha, fc_host_symbolic_name(shost));
>  }
>  
> +static void
> +qla2x00_set_host_system_hostname(struct Scsi_Host *shost)
> +{
> +	scsi_qla_host_t *ha = to_qla_host(shost);
> +
> +	set_bit(REGISTER_FDMI_NEEDED, &ha->dpc_flags);
> +}

I think you should allow to set and clear that flag by echoing 1 respectively 0 to the
file.  Also it might make sense to have this attribute completely implemented at the
transport-level.