From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SCSI sd: fix module init/exit error handling
Date: Tue, 10 Oct 2006 10:37:06 +0100 [thread overview]
Message-ID: <20061010093706.GJ395@infradead.org> (raw)
In-Reply-To: <20061004093254.GA15585@havoc.gtf.org>
On Wed, Oct 04, 2006 at 05:32:54AM -0400, Jeff Garzik wrote:
>
> - Properly handle and unwind errors in init_sd(). Fixes leaks on error,
> if class_register() or scsi_register_driver() failed.
>
> - Ensure that exit_sd() execution order is the perfect inverse of
> initialization order.
>
> FIXME: If some-but-not-all register_blkdev() calls fail, we wind up
> calling unregister_blkdev() for block devices we did not register.
> This was a pre-existing bug.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Ok.
prev parent reply other threads:[~2006-10-10 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 9:32 [PATCH] SCSI sd: fix module init/exit error handling Jeff Garzik
2006-10-10 9:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010093706.GJ395@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox