From: Swen Schillig <swen@vnet.ibm.com>
To: James Bottomley <james.bottomley@steeleye.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value
Date: Thu, 12 Oct 2006 11:43:44 +0200 [thread overview]
Message-ID: <200610121143.44321.swen@vnet.ibm.com> (raw)
In-Reply-To: <1160579121.3447.21.camel@mulgrave.il.steeleye.com>
Sorry James
won't happen again.
###############################################
commit 9ceca33ffd6287163e39030f3a5c6fad60d17f7b
Author: Swen Schillig <swen@vnet.ibm.com>
Date: Thu Oct 12 11:24:54 2006 +0200
Define ZFCP_MAX_SECTORS and initialize scsi_host_template.max_sectors
with appropriate value.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 8f88269..74c0eac 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390/scsi/zfcp_def.h
@@ -107,6 +107,10 @@ #define ZFCP_MAX_SBALES_PER_REQ \
(ZFCP_MAX_SBALS_PER_REQ * ZFCP_MAX_SBALES_PER_SBAL - 2)
/* request ID + QTCB in SBALE 0 + 1 of first SBAL in chain */
+#define ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
+ /* max. number of (data buffer) SBALEs in largest SBAL chain
+ multiplied with number of sectors per 4k block */
+
/* FIXME(tune): free space should be one max. SBAL chain plus what? */
#define ZFCP_QDIO_PCI_INTERVAL (QDIO_MAX_BUFFERS_PER_Q \
- (ZFCP_MAX_SBALS_PER_REQ + 4))
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
index 4d2bc79..452d96f 100644
--- a/drivers/s390/scsi/zfcp_scsi.c
+++ b/drivers/s390/scsi/zfcp_scsi.c
@@ -58,6 +58,7 @@ struct zfcp_data zfcp_data = {
.cmd_per_lun = 1,
.use_clustering = 1,
.sdev_attrs = zfcp_sysfs_sdev_attrs,
+ .max_sectors = ZFCP_MAX_SECTORS,
},
.driver_version = ZFCP_VERSION,
};
On Wednesday 11 October 2006 17:05, you wrote:
> On Mon, 2006-10-09 at 15:33 +0200, Swen Schillig wrote:
> > commit 7f3c3e955cfba57c4d95706c326d9c5b2f92e941
> > Author: Swen Schillig <swen@vnet.ibm.com>
> > Date: Mon Oct 9 14:59:08 2006 +0200
> >
> > Define (ZFCP_MAX_SECTORS) and initialize scsi_host_template.max_sectors with
> > appropriate value.
> >
> > ZFCP_MAX_SECTORS (ZFCP_MAX_SBALES_PER_REQ * 8)
> > /* max. number of (data buffer) SBALEs in largest SBAL chain
> > multiplied with number of sectors per 4k block */
>
> This needs a signoff.
>
> Plus it doesn't apply: it looks like your mailer has converted tabs to
> spaces.
>
> James
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2006-10-12 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 13:33 [PATCH] zfcp: initialize scsi_host_template.max_sectors with appropriate value Swen Schillig
2006-10-11 15:05 ` James Bottomley
2006-10-12 9:43 ` Swen Schillig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610121143.44321.swen@vnet.ibm.com \
--to=swen@vnet.ibm.com \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox