public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: "Moore, Eric" <Eric.Moore@lsil.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] Fusion: Call pci_set_mwi()
Date: Fri, 13 Oct 2006 10:24:52 -0600	[thread overview]
Message-ID: <20061013162452.GB11633@parisc-linux.org> (raw)


Hi Eric,

Even though the 1030 is a PCI-X device, it can still be plugged into a PCI
bus, and end up operating in PCI mode.  According to the documentation,
it will benefit from using MWI and MRM commands, but in order to do so
under Linux, we need to call pci_set_mwi(), which is what this patch does.
Please apply.

P.S. The if condition is just to avoid the warning from __must_check.
Most device drivers do need to check and adjust their internal flags if
it fails, but according to the 1030 manual, the chip automatically
decides when to use MWI.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 29d0635..d301a67 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -1153,6 +1153,9 @@ #endif
 	if (pci_enable_device(pdev))
 		return r;
 
+	if (pci_set_mwi(pdev))
+		/* We don't have to do anything if it fails */;
+
 	dinitprintk((KERN_WARNING MYNAM ": mpt_adapter_install\n"));
 
 	if (!pci_set_dma_mask(pdev, DMA_64BIT_MASK)) {


             reply	other threads:[~2006-10-13 16:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 16:24 Matthew Wilcox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-01-19 21:03 [PATCH] Fusion: Call pci_set_mwi() Moore, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061013162452.GB11633@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=Eric.Moore@lsil.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox