Re: Fw: garbled usb storage scsi vendor & model in 2.6.19-rc1

[Matthew Dharm <mdharm-scsi@one-eyed-alien.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]

On Tue, Oct 24, 2006 at 02:43:22PM -0700, Phil Dibowitz wrote:
> Alan Stern wrote:
> > There's a comment about this in the source code, asking what should be
> > done if the INQUIRY response is too short (as it is here).  Maybe the best
> > approach would be always to assume the first 36 bytes are valid, even when
> > the device says they aren't.  It ought to solve your problem, and it's
> > no worse than what we're doing now.
> > 
> > The patch is below.  This replaces the patch I sent earlier.
> 
> Perhaps a better approach might be to set the product and vendor to some
> specific string if the device says it isn't providing one? In the new model,
> can't we still have the chance of showing garbage if the device really isn't
> setting anything useful? So what if we show "Unknown" and "Unknown" or
> something similar in the event that the device sets the 'invalid' bit?

US_FL_FIX_INQUIRY used to do this; I don't remember what it does currently.

Regardless, the SCSI core should probably blank those data buffers before
deciding if any data is going to be copied into them.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

C:  Like the Furby?
DP: He gives me the creeps.  Think the SPCA will take him?
					-- Cobb and Dust Puppy
User Friendly, 1/2/1999

[-- Attachment #1.2: Type: application/pgp-signature, Size: 191 bytes --]

[-- Attachment #2: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 191 bytes --]

_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel