From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>
Cc: Benny Halevy <bhalevy@panasas.com>,
linux-scsi@vger.kernel.org, Mike Christie <mchristi@redhat.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
Jens Axboe <jens.axboe@oracle.com>, Dalit Naor <DALIT@il.ibm.com>,
Liran Schour <LIRANS@il.ibm.com>,
Sami.Iren@seagate.com, Daniel.E.Messinger@seagate.com,
stuart.brodsky@seagate.com, open-iscsi@googlegroups.com,
Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [RFC] support for bidirectional transfers and variable length CDBs
Date: Sun, 29 Oct 2006 12:30:04 -0700 [thread overview]
Message-ID: <20061029193004.GV5591@parisc-linux.org> (raw)
In-Reply-To: <20061028163609.GA17317@infradead.org>
On Sat, Oct 28, 2006 at 05:36:09PM +0100, Christoph Hellwig wrote:
> This should be an entirely separate patch. (As should your updates to
> the list of scsi device types and the typo fix in a comment in your
> patch)
Actually, the update to the list of device types is already in Linus' tree
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4ff36718ede26ee2da73f2dae94d71e2b06845fc
> I haven't looked at this code in detail but it looks rather
> messy already ;-) I'd prefer if we could postponed implementing this
> properly until we've landed bidi support.
I think we should encapsulate:
- int write = (data_direction == DMA_TO_DEVICE);
+ int write = ((data_direction == DMA_TO_DEVICE) || (data_direction == DMA_BIDIRECTIONAL));
into something like:
- int write = (data_direction == DMA_TO_DEVICE);
+ int write = is_dma_write(data_direction);
prev parent reply other threads:[~2006-10-29 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4541F822.70700@panasas.com>
2006-10-28 16:36 ` [RFC] support for bidirectional transfers and variable length CDBs Christoph Hellwig
2006-10-29 13:33 ` Benny Halevy
2006-10-29 13:48 ` Christoph Hellwig
2006-10-30 12:55 ` James Smart
2006-10-29 19:30 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061029193004.GV5591@parisc-linux.org \
--to=matthew@wil.cx \
--cc=DALIT@il.ibm.com \
--cc=Daniel.E.Messinger@seagate.com \
--cc=James.Bottomley@SteelEye.com \
--cc=LIRANS@il.ibm.com \
--cc=Sami.Iren@seagate.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=open-iscsi@googlegroups.com \
--cc=stuart.brodsky@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox