public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Roman Zippel <zippel@linux-m68k.org>,
	jejb <james.bottomley@steeleye.com>
Cc: Toralf F_rster <toralf.foerster@gmx.de>,
	scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: [PATCH] SCSI: ISCSI build failure
Date: Mon, 30 Oct 2006 08:32:30 -0800	[thread overview]
Message-ID: <20061030083230.5e889415.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0610301206240.6761@scrub.home>

On Mon, 30 Oct 2006 12:07:48 +0100 (CET) Roman Zippel wrote:

> Hi,
> 
> On Sun, 29 Oct 2006, Randy Dunlap wrote:
> 
> > On Sun, 29 Oct 2006 19:45:15 +0100 Toralf Förster wrote:
> > 
> > > Hello,
> > 
> > config SCSI_ISCSI_ATTRS
> > 	tristate "iSCSI Transport Attributes"
> > 	depends on SCSI && NET
> > 	help
> > 	  If you wish to export transport-specific information about
> > 	  each attached iSCSI device to sysfs, say Y.
> > 	  Otherwise, say N.
> > 
> > but NET is disabled, yet somehow SCSI_ISCSI_ATTRS is enabled.
> > I don't see how that happens.
> > Roman, any ideas?
> > 
> > [...]
> > > CONFIG_SCSI_QLA_ISCSI=y
> 
> I guess, that needs a dependency on NET.

Yep, thanks, Roman.

James, should be in 2.6.19...

---

From: Randy Dunlap <randy.dunlap@oracle.com>

SCSI_QLA_ISCSI needs to depend on NET to prevent build (link) failures
that are caused by selecting SCSI_ISCSI_ATTRS.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/qla4xxx/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.19-rc3-git6.orig/drivers/scsi/qla4xxx/Kconfig
+++ linux-2.6.19-rc3-git6/drivers/scsi/qla4xxx/Kconfig
@@ -1,6 +1,6 @@
 config SCSI_QLA_ISCSI
 	tristate "QLogic ISP4XXX host adapter family support"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && NET
 	select SCSI_ISCSI_ATTRS
 	---help---
 	This driver supports the QLogic 40xx (ISP4XXX) iSCSI host
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2006-10-30 16:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-29 18:45 Fwd: linux-2.6.19-rc3-g2da6dc28 build #105 failed Toralf Förster
2006-10-30  3:03 ` Randy Dunlap
2006-10-30 11:07   ` Roman Zippel
2006-10-30 16:32     ` Randy Dunlap [this message]
2006-10-31 20:51       ` [PATCH] SCSI: ISCSI build failure James Bottomley
2006-10-31 20:49         ` Randy Dunlap
2006-10-31 21:03           ` James Bottomley
2006-10-31 21:02             ` Randy Dunlap
2006-10-31 21:12               ` James Bottomley
2006-10-31 21:13                 ` Randy Dunlap
2006-11-01  0:00         ` Roman Zippel
2006-11-01 15:26           ` James Bottomley
2006-11-01 15:36             ` Matthew Wilcox
2006-11-01 16:03               ` Randy Dunlap
2006-11-01 16:18               ` Arjan van de Ven
2006-11-01 21:57               ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061030083230.5e889415.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@osdl.org \
    --cc=james.bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox