From: Matthew Wilcox <matthew@wil.cx>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] [SCSI] st.c : fix up log messages format
Date: Fri, 3 Nov 2006 06:32:17 -0700 [thread overview]
Message-ID: <20061103133217.GC27140@parisc-linux.org> (raw)
In-Reply-To: <20061103092512.88130.qmail@web31807.mail.mud.yahoo.com>
On Fri, Nov 03, 2006 at 01:25:12AM -0800, Luben Tuikov wrote:
> sdev_printk(KERN_WARNING, SDp,
> - "Attached scsi tape %s", tape_name(tpnt));
> - printk(KERN_WARNING "%s: try direct i/o: %s (alignment %d B)\n",
> - tape_name(tpnt), tpnt->try_dio ? "yes" : "no",
> - queue_dma_alignment(SDp->request_queue) + 1);
> + "Attached scsi tape %s\n", tape_name(tpnt));
> + sdev_printk(KERN_WARNING, SDp,
> + "%s: try direct i/o: %s (alignment %d bytes)\n",
> + tape_name(tpnt), tpnt->try_dio ? "yes" : "no",
> + queue_dma_alignment(SDp->request_queue) + 1);
>
I know you didn't change this ... but why are these KERN_WARNING?
Surely KERN_INFO is more appropriate here?
next prev parent reply other threads:[~2006-11-03 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 9:25 [PATCH] [SCSI] st.c : fix up log messages format Luben Tuikov
2006-11-03 13:32 ` Matthew Wilcox [this message]
2006-11-07 19:56 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061103133217.GC27140@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox