From: Andrew Morton <akpm@osdl.org>
To: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
schwidefsky@de.ibm.com
Subject: Re: [patch 2/2] libsas fails to compile on s390
Date: Thu, 9 Nov 2006 00:34:07 -0800 [thread overview]
Message-ID: <20061109003407.f2c5ea5b.akpm@osdl.org> (raw)
In-Reply-To: <200611090357.kA93vA1u004099@shell0.pdx.osdl.net>
On Wed, 08 Nov 2006 19:57:09 -0800
akpm@osdl.org wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Explicitly include scatterlist.h in sas_internal.h to avoid the implicit
> include dependency via the pci.h header. For s390 the scatterlist.h header
> is not included because CONFIG_PCI=n.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: James Bottomley <James.Bottomley@steeleye.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/scsi/libsas/sas_internal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -puN drivers/scsi/libsas/sas_internal.h~libsas-fails-to-compile-on-s390 drivers/scsi/libsas/sas_internal.h
> --- a/drivers/scsi/libsas/sas_internal.h~libsas-fails-to-compile-on-s390
> +++ a/drivers/scsi/libsas/sas_internal.h
> @@ -26,6 +26,7 @@
> #ifndef _SAS_INTERNAL_H_
> #define _SAS_INTERNAL_H_
>
> +#include <linux/scatterlist.h>
> #include <scsi/scsi.h>
> #include <scsi/scsi_host.h>
> #include <scsi/scsi_transport_sas.h>
err, please ignore this one....
In file included from include/linux/scatterlist.h:5,
from drivers/scsi/libsas/sas_internal.h:30,
from drivers/scsi/libsas/sas_phy.c:26:
include/asm/scatterlist.h:7: error: expected specifier-qualifier-list before 'dma_addr_t'
In file included from drivers/scsi/libsas/sas_internal.h:30,
from drivers/scsi/libsas/sas_phy.c:26:
include/linux/scatterlist.h: In function 'sg_set_buf':
include/linux/scatterlist.h:13: error: 'struct scatterlist' has no member named 'length'
In file included from include/linux/dma-mapping.h:35,
from include/asm-generic/pci-dma-compat.h:8,
from include/asm/pci.h:135,
from include/linux/pci.h:717,
from include/scsi/libsas.h:32,
from drivers/scsi/libsas/sas_internal.h:34,
from drivers/scsi/libsas/sas_phy.c:26:
include/asm/dma-mapping.h: In function 'dma_map_sg':
include/asm/dma-mapping.h:44: error: 'struct scatterlist' has no member named 'length'
include/asm/dma-mapping.h:44: warning: type defaults to 'int' in declaration of '__ret_warn_on'
include/asm/dma-mapping.h:44: error: 'struct scatterlist' has no member named 'length'
include/asm/dma-mapping.h:49: error: 'struct scatterlist' has no member named 'dma_address'
distcc[16143] ERROR: compile drivers/scsi/libsas/sas_phy.c on bix/32 failed
make[1]: *** [drivers/scsi/libsas/sas_phy.o] Error 1
make: *** [drivers/scsi/libsas/sas_phy.o] Error 2
next prev parent reply other threads:[~2006-11-09 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 3:57 [patch 2/2] libsas fails to compile on s390 akpm
2006-11-09 8:34 ` Andrew Morton [this message]
2006-11-10 7:50 ` Heiko Carstens
2006-11-10 8:39 ` Andrew Morton
2006-11-10 9:00 ` Heiko Carstens
2006-11-10 9:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109003407.f2c5ea5b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox