Re: [patch 2/2] libsas fails to compile on s390

Andrew Morton
2006-11-10T09:22:39Z

On Fri, 10 Nov 2006 10:00:44 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Fri, Nov 10, 2006 at 12:39:08AM -0800, Andrew Morton wrote:
> > > But maybe we should simply merge this one
> > > instead?
> > >
> > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/broken-out/git-sas-kconfig-fix.patch
> >
> > The original failure which we're tryimg to fix here occurred with that
> > patch applied.
> >
> > Oh well.
>
> How that? s390 doesn't have CONFIG_ATA... This compile error only happens on
> 2.6.19-rc5 but not your -mm tree. That's why I thought the above mentioned
> patch should fix this.
> Maybe SCSI_SAS_LIBSAS should depend on SCSI && ATA && PCI?

umm, with git-sas-kconfig-fix.patch applied, `make allmodconfig' does:

box:/usr/src/25> grep SAS .config
CONFIG_SCSI_SAS_ATTRS=m

and... it compiles. I must be dreaming.