From: Andrew Morton <akpm@osdl.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
schwidefsky@de.ibm.com
Subject: Re: [patch 2/2] libsas fails to compile on s390
Date: Fri, 10 Nov 2006 01:22:29 -0800 [thread overview]
Message-ID: <20061110012229.6e61ad25.akpm@osdl.org> (raw)
In-Reply-To: <20061110090044.GE7129@osiris.boeblingen.de.ibm.com>
On Fri, 10 Nov 2006 10:00:44 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> On Fri, Nov 10, 2006 at 12:39:08AM -0800, Andrew Morton wrote:
> > > But maybe we should simply merge this one
> > > instead?
> > >
> > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/broken-out/git-sas-kconfig-fix.patch
> >
> > The original failure which we're tryimg to fix here occurred with that
> > patch applied.
> >
> > Oh well.
>
> How that? s390 doesn't have CONFIG_ATA... This compile error only happens on
> 2.6.19-rc5 but not your -mm tree. That's why I thought the above mentioned
> patch should fix this.
> Maybe SCSI_SAS_LIBSAS should depend on SCSI && ATA && PCI?
umm, with git-sas-kconfig-fix.patch applied, `make allmodconfig' does:
box:/usr/src/25> grep SAS .config
CONFIG_SCSI_SAS_ATTRS=m
and... it compiles. I must be dreaming.
prev parent reply other threads:[~2006-11-10 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 3:57 [patch 2/2] libsas fails to compile on s390 akpm
2006-11-09 8:34 ` Andrew Morton
2006-11-10 7:50 ` Heiko Carstens
2006-11-10 8:39 ` Andrew Morton
2006-11-10 9:00 ` Heiko Carstens
2006-11-10 9:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110012229.6e61ad25.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=James.Bottomley@steeleye.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox