From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [linux-usb-devel] 2.6.19-rc5-mm1 Date: Fri, 10 Nov 2006 23:17:25 +0300 Message-ID: <20061110201725.GA7341@localhost> References: <20061109192658.GA2560@inferi.kami.home> <20061109145100.01d6ec46.akpm@osdl.org> <20061109161123.f9cea1e7.akpm@osdl.org> Reply-To: cbou@mail.ru Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Return-path: Content-Disposition: inline In-Reply-To: <20061109161123.f9cea1e7.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: =?koi8-r?B?PT9JU08tODg1OS0xP1E/?= C=E9dric?= Augonnet , Alan Stern , Benoit Boissinot , Mattia Dongili , USB development list , Kernel development list , SCSI development list , kernel-discuss@handhelds.org List-Id: linux-scsi@vger.kernel.org On Thu, Nov 09, 2006 at 04:11:23PM -0800, Andrew Morton wrote: > On Fri, 10 Nov 2006 00:39:46 +0100 > "C__dric Augonnet" wrote: > > > 2006/11/9, Andrew Morton : > > > > > > > > hm. Maybe it's the disk_sysfs_symlinks() changes. > > > > > > Could someone who can reproduce this please try this revert, on > > > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1? [...] > > > > Hi, > > > > This patch seems to be working : whereas i had the same oops as Mattia > > each time I unplugged my USB external DD drive, now it does not happen > > anymore. > > Thank you very much for this one ! > > > > OK, thanks. I dropped the patch. So ide-cs will now start deadlocking > again. No, it will not. I'm really sorry, mainline was already fixed at 2.6.17-rc5 time by that commit: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=1a2acc9e9214699a99389e323e6686e9e0e2ca67 But for some reason handhelds.org kernel tree's block/genhd.c file was unsynchronized with mainline. I've revealed that only after my patch was removed and I've started to investigate SCSI oops issue triggered by my patch. Resume: mainline do not need my patch, handhelds.org's kernel should be synchronized with mainline. -- Anton (irc: bd2)