From: Matthew Wilcox <matthew@wil.cx>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Grant Grundler <grundler@parisc-linux.org>,
linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net,
Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 4/5] e1000 : Make Intel e1000 driver legacy I/O port free
Date: Wed, 22 Nov 2006 06:54:23 -0700 [thread overview]
Message-ID: <20061122135423.GV18567@parisc-linux.org> (raw)
In-Reply-To: <1164185809.31358.714.camel@laptopd505.fenrus.org>
On Wed, Nov 22, 2006 at 09:56:49AM +0100, Arjan van de Ven wrote:
> On Wed, 2006-11-22 at 17:06 +0900, Hidetoshi Seto wrote:
> > static struct pci_device_id e1000_pci_tbl[] = {
> > + INTEL_E1000_ETHERNET_DEVICE(0x1004, 0),
> > + INTEL_E1000_ETHERNET_DEVICE(0x1008, E1000_USE_IOPORT),
>
> Hi,
>
> this has the unfortunate effect that it's now a lot harder to add PCI
> ID's to this driver at runtime via sysfs ;(
It does? Normally you get 0 passed in that field, so you'll just not
get io ports enabled ...
Need to set use_driver_data to get non-0 passed in that field.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-11-22 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 8:06 [PATCH 4/5] e1000 : Make Intel e1000 driver legacy I/O port free Hidetoshi Seto
2006-11-22 8:56 ` Arjan van de Ven
2006-11-22 13:54 ` Matthew Wilcox [this message]
2006-11-22 16:11 ` Auke Kok
2006-11-23 6:16 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122135423.GV18567@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox