From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 4/5] e1000 : Make Intel e1000 driver legacy I/O port free Date: Wed, 22 Nov 2006 06:54:23 -0700 Message-ID: <20061122135423.GV18567@parisc-linux.org> References: <4564050C.70607@jp.fujitsu.com> <1164185809.31358.714.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1164185809.31358.714.camel@laptopd505.fenrus.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net To: Arjan van de Ven Cc: Andrew Morton , Hidetoshi Seto , Grant Grundler , linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net, Greg KH , Linux Kernel list , Kenji Kaneshige , linux-pci@atrey.karlin.mff.cuni.cz List-Id: linux-scsi@vger.kernel.org On Wed, Nov 22, 2006 at 09:56:49AM +0100, Arjan van de Ven wrote: > On Wed, 2006-11-22 at 17:06 +0900, Hidetoshi Seto wrote: > > static struct pci_device_id e1000_pci_tbl[] = { > > + INTEL_E1000_ETHERNET_DEVICE(0x1004, 0), > > + INTEL_E1000_ETHERNET_DEVICE(0x1008, E1000_USE_IOPORT), > > Hi, > > this has the unfortunate effect that it's now a lot harder to add PCI > ID's to this driver at runtime via sysfs ;( It does? Normally you get 0 passed in that field, so you'll just not get io ports enabled ... Need to set use_driver_data to get non-0 passed in that field. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV