From: Alan <alan@lxorguk.ukuu.org.uk>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Andrew Morton <akpm@osdl.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Grant Grundler <grundler@parisc-linux.org>,
linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net,
Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 3/5] PCI : Add selected_regions funcs
Date: Thu, 23 Nov 2006 21:42:48 +0000 [thread overview]
Message-ID: <20061123214248.6251a4c0@localhost.localdomain> (raw)
In-Reply-To: <200611232033.35280.ioe-lkml@rameria.de>
On Thu, 23 Nov 2006 20:33:32 +0100
Ingo Oeser <ioe-lkml@rameria.de> wrote:
> Hi Hidetoshi Seto,
>
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".
There are a fixed number of BARs , besides which the interface already
uses int for the mask in pci_enable_device_bars() so the use of int is
fine and continues the existing API.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2006-11-23 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 8:06 [PATCH 3/5] PCI : Add selected_regions funcs Hidetoshi Seto
2006-11-23 19:33 ` Ingo Oeser
2006-11-23 19:39 ` Matthew Wilcox
2006-11-23 21:42 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061123214248.6251a4c0@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=ioe-lkml@rameria.de \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox