From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH 3/5] PCI : Add selected_regions funcs Date: Thu, 23 Nov 2006 21:42:48 +0000 Message-ID: <20061123214248.6251a4c0@localhost.localdomain> References: <456404FE.1040708@jp.fujitsu.com> <200611232033.35280.ioe-lkml@rameria.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200611232033.35280.ioe-lkml@rameria.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net To: Ingo Oeser Cc: Andrew Morton , Hidetoshi Seto , Grant Grundler , linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net, Greg KH , Linux Kernel list , Kenji Kaneshige , linux-pci@atrey.karlin.mff.cuni.cz List-Id: linux-scsi@vger.kernel.org On Thu, 23 Nov 2006 20:33:32 +0100 Ingo Oeser wrote: > Hi Hidetoshi Seto, > > bitfields (and bitmask) should be unsigned and use machine word size, > which is usually "long". So please pass them in "unsigned long" instead of "int". There are a fixed number of BARs , besides which the interface already uses int for the mask in pci_enable_device_bars() so the use of int is fine and continues the existing API. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV