From: Jens Axboe <jens.axboe@oracle.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove blk_queue_activity_fn
Date: Tue, 5 Dec 2006 10:17:06 +0100 [thread overview]
Message-ID: <20061205091705.GR4392@kernel.dk> (raw)
In-Reply-To: <45753738.3030607@panasas.com>
On Tue, Dec 05 2006, Boaz Harrosh wrote:
> While working on bidi support at struct request level
> I have found that blk_queue_activity_fn is actually never used.
> The only user is in ide-probe.c with this code:
>
> /* enable led activity for disk drives only */
> if (drive->media == ide_disk && hwif->led_act)
> blk_queue_activity_fn(q, hwif->led_act, drive);
>
> And led_act is never initialized anywhere.
> (Looking back at older kernels it was used in the PPC arch, but was removed around 2.6.18)
> Unless it is all for future use off course.
> (this patch is against linux-2.6-block.git as off 2006/12/4)
I didn't notice it had been removed from pmac in 2.6.18, since that is
the case we can kill it. Thanks, I've queued the patch for inclusion.
--
Jens Axboe
prev parent reply other threads:[~2006-12-05 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 9:09 [PATCH] remove blk_queue_activity_fn Boaz Harrosh
2006-12-05 9:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061205091705.GR4392@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bharrosh@panasas.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox