* [PATCH] remove unnecessary blk_queue_bounce in SG_IO
@ 2006-12-11 22:52 FUJITA Tomonori
2006-12-12 9:27 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: FUJITA Tomonori @ 2006-12-11 22:52 UTC (permalink / raw)
To: jens.axboe; +Cc: linux-scsi
When I converted the origianl patch, I left unnecessary
blk_queue_bounce in SG_IO.
---
[PATCH] remove unnecessary blk_queue_bounce in SG_IO
This patch removes blk_queue_bounce in SG_IO since the blk functions
handle it.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 045cabd..f322b6a 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -271,13 +271,6 @@ static int sg_io(struct file *file, requ
rq->cmd_type = REQ_TYPE_BLOCK_PC;
- /*
- * bounce this after holding a reference to the original bio, it's
- * needed for proper unmapping
- */
- if (rq->bio)
- blk_queue_bounce(q, &rq->bio);
-
rq->timeout = jiffies_to_msecs(hdr->timeout);
if (!rq->timeout)
rq->timeout = q->sg_timeout;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remove unnecessary blk_queue_bounce in SG_IO
2006-12-11 22:52 [PATCH] remove unnecessary blk_queue_bounce in SG_IO FUJITA Tomonori
@ 2006-12-12 9:27 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2006-12-12 9:27 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: linux-scsi
On Tue, Dec 12 2006, FUJITA Tomonori wrote:
> When I converted the origianl patch, I left unnecessary
> blk_queue_bounce in SG_IO.
>
> ---
> [PATCH] remove unnecessary blk_queue_bounce in SG_IO
>
> This patch removes blk_queue_bounce in SG_IO since the blk functions
> handle it.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-12 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-11 22:52 [PATCH] remove unnecessary blk_queue_bounce in SG_IO FUJITA Tomonori
2006-12-12 9:27 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox