From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, dougg@torque.net
Subject: Re: [PATCH 0/3] SG v4 support
Date: Fri, 15 Dec 2006 19:57:05 +0100 [thread overview]
Message-ID: <20061215185704.GZ5010@kernel.dk> (raw)
In-Reply-To: <20061216001753F.fujita.tomonori@lab.ntt.co.jp>
On Sat, Dec 16 2006, FUJITA Tomonori wrote:
> The following patches add SG v4 support to bsg. They are over Jens'
> bsg branch.
>
> I just replaced bsg's SG v3 support with SG v4 and haven't added
> anything new yet. So it can only handle SCSI commands.
Good start! Just one comment before I look over this and merge it - I'd
prefer keeping this out of sg.c. One of the problems we have right now
are dual pieces of code for sg v3, and I think it would be silly to
continue down this path. Lets keep sg.c as a legacy sg v3 interface
(it'll be the only one except SG_IO in the block layer), and let bsg
take sg v4 and forward.
There's really zero gain in having it in two places.
IOW, put the sg v4 structure in bsg.h.
> I've uploaded simple programs to just read/write by using SG v4:
>
> http://www.kernel.org/pub/linux/kernel/people/tomo/sg4/
Great!
I'll get this reviewed and merged as soon as I can, probably monday.
--
Jens Axboe
next prev parent reply other threads:[~2006-12-15 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 15:18 [PATCH 0/3] SG v4 support FUJITA Tomonori
2006-12-15 18:57 ` Jens Axboe [this message]
2006-12-15 19:41 ` James Bottomley
2006-12-15 20:03 ` Jens Axboe
2006-12-19 13:55 ` FUJITA Tomonori
2006-12-19 14:02 ` Jens Axboe
2006-12-19 14:09 ` Jens Axboe
2006-12-19 14:25 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215185704.GZ5010@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dougg@torque.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox