From: Jens Axboe <jens.axboe@oracle.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, dougg@torque.net
Subject: Re: [PATCH 0/3] SG v4 support
Date: Fri, 15 Dec 2006 21:03:02 +0100 [thread overview]
Message-ID: <20061215200302.GA5010@kernel.dk> (raw)
In-Reply-To: <1166211700.2846.48.camel@mulgrave.il.steeleye.com>
On Fri, Dec 15 2006, James Bottomley wrote:
> On Fri, 2006-12-15 at 19:57 +0100, Jens Axboe wrote:
> > Good start! Just one comment before I look over this and merge it -
> > I'd
> > prefer keeping this out of sg.c. One of the problems we have right now
> > are dual pieces of code for sg v3, and I think it would be silly to
> > continue down this path. Lets keep sg.c as a legacy sg v3 interface
> > (it'll be the only one except SG_IO in the block layer), and let bsg
> > take sg v4 and forward.
> >
> > There's really zero gain in having it in two places.
>
> There is a slight complexity here in that sg is the only thing that
> attaches to things like processor devices, or other devices we have no
> ULD for; so if we want sg v4 exposed to them, we need to at least route
> sg though this ioctl.
Rather a little pain for something like that, than the pain of
duplicating and maintaining that code.
--
Jens Axboe
next prev parent reply other threads:[~2006-12-15 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 15:18 [PATCH 0/3] SG v4 support FUJITA Tomonori
2006-12-15 18:57 ` Jens Axboe
2006-12-15 19:41 ` James Bottomley
2006-12-15 20:03 ` Jens Axboe [this message]
2006-12-19 13:55 ` FUJITA Tomonori
2006-12-19 14:02 ` Jens Axboe
2006-12-19 14:09 ` Jens Axboe
2006-12-19 14:25 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215200302.GA5010@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@SteelEye.com \
--cc=dougg@torque.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox